* [PATCH 1/2] video: udlfb: Constify read only data
@ 2018-01-15 16:59 Ladislav Michl
2018-01-16 15:34 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Ladislav Michl @ 2018-01-15 16:59 UTC (permalink / raw)
To: linux-fbdev
Both dlfb_fix and fb_device_attrs are never written to, so
it is safe to make them const.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
drivers/video/fbdev/udlfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 47e31668f316..f0118c10b4ab 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -32,7 +32,7 @@
#include <video/udlfb.h>
#include "edid.h"
-static struct fb_fix_screeninfo dlfb_fix = {
+static const struct fb_fix_screeninfo dlfb_fix = {
.id = "udlfb",
.type = FB_TYPE_PACKED_PIXELS,
.visual = FB_VISUAL_TRUECOLOR,
@@ -1455,7 +1455,7 @@ static const struct bin_attribute edid_attr = {
.write = edid_store
};
-static struct device_attribute fb_device_attrs[] = {
+static const struct device_attribute fb_device_attrs[] = {
__ATTR_RO(metrics_bytes_rendered),
__ATTR_RO(metrics_bytes_identical),
__ATTR_RO(metrics_bytes_sent),
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] video: udlfb: Constify read only data
2018-01-15 16:59 [PATCH 1/2] video: udlfb: Constify read only data Ladislav Michl
@ 2018-01-16 15:34 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-16 15:34 UTC (permalink / raw)
To: linux-fbdev
On Monday, January 15, 2018 05:59:46 PM Ladislav Michl wrote:
> Both dlfb_fix and fb_device_attrs are never written to, so
> it is safe to make them const.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-16 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 16:59 [PATCH 1/2] video: udlfb: Constify read only data Ladislav Michl
2018-01-16 15:34 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).