* [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()
@ 2017-11-24 21:28 SF Markus Elfring
2017-11-24 21:30 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_ Rolf Eike Beer
0 siblings, 1 reply; 8+ messages in thread
From: SF Markus Elfring @ 2017-11-24 21:28 UTC (permalink / raw)
To: dri-devel, linux-fbdev, linux-parisc, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 24 Nov 2017 22:22:06 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 6ded5c198998..fe217a2f7d21 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENODEV;
- }
info = &fb->info;
--
2.15.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_
2017-11-24 21:28 [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() SF Markus Elfring
@ 2017-11-24 21:30 ` Rolf Eike Beer
2017-12-29 18:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 8+ messages in thread
From: Rolf Eike Beer @ 2017-11-24 21:30 UTC (permalink / raw)
To: SF Markus Elfring
Cc: dri-devel, linux-fbdev, linux-parisc, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley, LKML, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 24 Nov 2017 22:22:06 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/video/fbdev/stifb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
> index 6ded5c198998..fe217a2f7d21 100644
> --- a/drivers/video/fbdev/stifb.c
> +++ b/drivers/video/fbdev/stifb.c
> @@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct
> *sti, int bpp_pref) int bpp, xres, yres;
>
> fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
> - if (!fb) {
> - printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
> + if (!fb)
> return -ENODEV;
> - }
>
> info = &fb->info;
This should be -ENOMEM.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_
2017-11-24 21:30 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_ Rolf Eike Beer
@ 2017-12-29 18:05 ` Bartlomiej Zolnierkiewicz
2018-01-07 11:55 ` [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb() SF Markus Elfring
0 siblings, 1 reply; 8+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-12-29 18:05 UTC (permalink / raw)
To: SF Markus Elfring
Cc: Rolf Eike Beer, dri-devel, linux-fbdev, linux-parisc,
Helge Deller, James E. J. Bottomley, LKML, kernel-janitors
On Friday, November 24, 2017 10:30:34 PM Rolf Eike Beer wrote:
> Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Fri, 24 Nov 2017 22:22:06 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> > drivers/video/fbdev/stifb.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
> > index 6ded5c198998..fe217a2f7d21 100644
> > --- a/drivers/video/fbdev/stifb.c
> > +++ b/drivers/video/fbdev/stifb.c
> > @@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct
> > *sti, int bpp_pref) int bpp, xres, yres;
> >
> > fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
> > - if (!fb) {
> > - printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
> > + if (!fb)
> > return -ENODEV;
> > - }
> >
> > info = &fb->info;
>
> This should be -ENOMEM.
Markus, please fix this issue first (before doing cleanups).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb()
2017-12-29 18:05 ` Bartlomiej Zolnierkiewicz
@ 2018-01-07 11:55 ` SF Markus Elfring
2018-01-07 11:56 ` [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb() SF Markus Elfring
2018-01-07 11:58 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_in SF Markus Elfring
0 siblings, 2 replies; 8+ messages in thread
From: SF Markus Elfring @ 2018-01-07 11:55 UTC (permalink / raw)
To: linux-fbdev, linux-parisc, dri-devel, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley, Rolf Eike Beer
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 12:45:54 +0100
Two update suggestions were taken into account.
Markus Elfring (2):
Return -ENOMEM after a failed kzalloc()
Delete an error message for a failed memory allocation
drivers/video/fbdev/stifb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()
2018-01-07 11:55 ` [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb() SF Markus Elfring
@ 2018-01-07 11:56 ` SF Markus Elfring
[not found] ` <CGME20180328133411epcas2p442e8f8a85d6c6e72ec5a5122519fe5eb@epcas2p4.samsung.com>
2018-01-07 11:58 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_in SF Markus Elfring
1 sibling, 1 reply; 8+ messages in thread
From: SF Markus Elfring @ 2018-01-07 11:56 UTC (permalink / raw)
To: linux-fbdev, linux-parisc, dri-devel, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley, Rolf Eike Beer
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 11:33:59 +0100
Replace an error code for the indication of a memory allocation failure
in this function.
Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac ("Linux-2.6.12-rc2: Initial git repository build")
Suggested-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/stifb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 6ded5c198998..511a594889af 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1128,7 +1128,7 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
if (!fb) {
printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
- return -ENODEV;
+ return -ENOMEM;
}
info = &fb->info;
--
2.15.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_in
2018-01-07 11:55 ` [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb() SF Markus Elfring
2018-01-07 11:56 ` [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb() SF Markus Elfring
@ 2018-01-07 11:58 ` SF Markus Elfring
[not found] ` <CGME20180328133621epcas2p2865976351cf3dc28ac258d2c9530ffcd@epcas2p2.samsung.com>
1 sibling, 1 reply; 8+ messages in thread
From: SF Markus Elfring @ 2018-01-07 11:58 UTC (permalink / raw)
To: linux-fbdev, linux-parisc, dri-devel, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley, Rolf Eike Beer
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 12:34:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
This update suggestion was rebased on source files from the software
"Linux next-20180105" together with a change for an error code.
drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 511a594889af..dec8efb4f256 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENOMEM;
- }
info = &fb->info;
--
2.15.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-28 13:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-24 21:28 [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() SF Markus Elfring
2017-11-24 21:30 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_ Rolf Eike Beer
2017-12-29 18:05 ` Bartlomiej Zolnierkiewicz
2018-01-07 11:55 ` [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb() SF Markus Elfring
2018-01-07 11:56 ` [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb() SF Markus Elfring
[not found] ` <CGME20180328133411epcas2p442e8f8a85d6c6e72ec5a5122519fe5eb@epcas2p4.samsung.com>
2018-03-28 13:34 ` Bartlomiej Zolnierkiewicz
2018-01-07 11:58 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_in SF Markus Elfring
[not found] ` <CGME20180328133621epcas2p2865976351cf3dc28ac258d2c9530ffcd@epcas2p2.samsung.com>
2018-03-28 13:36 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stif Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).