From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CC2EED616 for ; Fri, 15 Sep 2023 15:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbjIOPgM (ORCPT ); Fri, 15 Sep 2023 11:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230424AbjIOPfm (ORCPT ); Fri, 15 Sep 2023 11:35:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E14C8E6D; Fri, 15 Sep 2023 08:35:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26ECCC433C8; Fri, 15 Sep 2023 15:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694792137; bh=eh4hH43/skbLq/T9F77bp8BlsF0bG5I501rYqNbey9I=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=PPfKUYXYtMuseNUQg+5lGAAzQpjpqobvavjqmSNov9pCRHaXxXwA3VOahu6pTywRJ kF/716J3AjK2BZyzwSHbObop64Kf/Amu4S1oUefCLx2hVJZXs3V8yb7fTTTJrefYIc SV8L152VzFsrESorWxN6Snp17XhJl0SEaxrmi1r4OqtH81C1xvJ2A2gorhPxpgY79s fAnH1I0ZpHyhZxQ49Vzpxs1xw1VWS+nF1qPo36SEuPVcIA8DhAYrWEHEApdC5FUNG0 NfrwNWvCVqTOqy0yc1Mth7v5IK26vFM/p122KNYdozchdw4PgoccKsSOqkcPDzJH7E cwzCeNYaQiO+Q== Received: (nullmailer pid 3764874 invoked by uid 1000); Fri, 15 Sep 2023 15:35:35 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Flavio Suligoi Cc: Rob Herring , Pavel Machek , linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org, Krzysztof Kozlowski , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Helge Deller , Jingoo Han , devicetree@vger.kernel.org, Conor Dooley , Daniel Thompson In-Reply-To: <20230915140516.1294925-1-f.suligoi@asem.it> References: <20230915140516.1294925-1-f.suligoi@asem.it> Message-Id: <169479213508.3764858.9372771347269509988.robh@kernel.org> Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C Date: Fri, 15 Sep 2023 10:35:35 -0500 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, 15 Sep 2023 16:05:15 +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM input signal (PWM mode). > This driver supports both modes. > > For device driver details, please refer to: > - drivers/video/backlight/mp3309c_bl.c > > The datasheet is available at: > - https://www.monolithicpower.com/en/mp3309c.html > > Signed-off-by: Flavio Suligoi > --- > > v2: > - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0, > switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms, > reset-on-length-ms) > - add common.yaml# > - remove already included properties (default-brightness, max-brightness) > - substitute three boolean properties, used for the overvoltage-protection > values, with a single enum property > - remove some conditional definitions > - remove the 2nd example > v1: > - first version > > .../bindings/leds/backlight/mps,mp3309c.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.example.dtb: /example-0/i2c/backlight@17: failed to match any schema with compatible: ['mps,mp3309c-backlight'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230915140516.1294925-1-f.suligoi@asem.it The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.