From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9265C15C125; Tue, 17 Sep 2024 10:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726568992; cv=none; b=QSh737envWI4NXXExurzdAR29yNDdhwHVFFmcqEHKV/PhED8Qikyks5u4PL21y5czxhZEW/1W2jErLg5DM6CEpId0G3KXS44i9UiT5IwbT+i/12I2N1brSiEQ73s8G99oTE7A39V0UUKpZdGRYrZROPN5gAmWePheDJgIkbly4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726568992; c=relaxed/simple; bh=c/H/tfRaw4LC01NWd9KvPpt2hWz/gwUbwReNEUrEQGM=; h=Date:Content-Type:MIME-Version:From:To:Cc:In-Reply-To:References: Message-Id:Subject; b=bJFXVUK05kiRgNCHCS13Ig0jTwvFuFF16cPO3llT8t2vJK2STTVx+X7Y+scq9R8yDfGYp/wg6V+aGQMMKzLp7UwsjRFxPqDXTvcX7uq875yM2cAE/gGVrY65XNAjtO8g2uYENjIRpq4LHsI5MwWMonXjcY8Cyd8EHLdrdtglRkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CG/gd26B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CG/gd26B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E611CC4CEC5; Tue, 17 Sep 2024 10:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726568992; bh=c/H/tfRaw4LC01NWd9KvPpt2hWz/gwUbwReNEUrEQGM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=CG/gd26BikxAze7Iu2fVUT4cEwoGzGnozfSSh1x/xhxMpuFRFN5wK1M547BuTGPtO 7d9syGCWsZTzSwk7YKEieJbLlkxYcPDq2K1gssdEVaH7Kb3pqGfsYIxRUxIAtnqZ0p rUM9kZRhkcVj5YPgTjbiFRF70G49cCKdR+8rdhnS8/QPcs+20KLNvtPlNOI+f1pzAq /OuI0ANOSfRDrVCTb+H+MNTnT3JosDXy5X6WcfVtHR/y46FD+420oN314m522eUns5 O/Bbzxxc7wvNlyF8U+hy0DhXE4UpBPtRyFooxeVG9P9fjLRLWamAw4s88ROIoPZIm3 B0zq6NGo2rsPQ== Date: Tue, 17 Sep 2024 05:29:51 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Luca Ceresoli Cc: Thomas Zimmermann , David Airlie , linux-fbdev@vger.kernel.org, Dragan Cvetic , Greg Kroah-Hartman , Neil Armstrong , Derek Kiernan , Maxime Ripard , Robert Foss , Thomas Petazzoni , Jingoo Han , Andrzej Hajda , Maarten Lankhorst , Wolfram Sang , Krzysztof Kozlowski , Laurent Pinchart , Jonas Karlman , linux-kernel@vger.kernel.org, Paul Kocialkowski , linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Saravana Kannan , Paul Kocialkowski , Daniel Thompson , Helge Deller , devicetree@vger.kernel.org, "Rafael J. Wysocki" , Conor Dooley , Daniel Vetter , =?utf-8?q?Herv=C3=A9_Codina?= , Jernej Skrabec , Lee Jones , Arnd Bergmann In-Reply-To: <20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com> References: <20240917-hotplug-drm-bridge-v4-0-bc4dfee61be6@bootlin.com> <20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com> Message-Id: <172656899099.2713363.6775764159513105143.robh@kernel.org> Subject: Re: [PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug addon connector On Tue, 17 Sep 2024 10:53:05 +0200, Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. > > Signed-off-by: Luca Ceresoli > > --- > > Changed in v4: > - rename 'nobus-devices' to 'devices' > - use 'additionalProperties: true' for the 'devices' node (nodes are added > by overlays) > - document GPIO polarity > - add '|' for descriptions to preserve line breaks > - remove powergood-gpios (removed in hardware design) > - Omit "/" node, not needed and cause of warnings > - remove reference to v2 examples from example comment > - remove unneeded "addon_connector" label from example > > Changed in v3: > - change the layout to only add subnodes, not properties > - add the 'nobus-devices' node description to hold devices not on any bus > - add 'i2c-*' nodes for the I2C busses, using a i2c-parent phandle > - and the 'dsi' node for the DSI bus > - move the entire port@1 node to the overlay (not only the remote-endpoint > property) > - remove the overlay examples (Overlays in examples are not supported) > - add more clarifying descriptions and comments for examples > - some rewording > > This patch was added in v2. > --- > .../connector/ge,sunh-addon-connector.yaml | 177 +++++++++++++++++++++ > MAINTAINERS | 5 + > 2 files changed, 182 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: addon-connector: Unevaluated properties are not allowed ('powergood-gpios' was unexpected) from schema $id: http://devicetree.org/schemas/connector/ge,sunh-addon-connector.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.