* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ [not found] ` <031801ced626$7cca5820$765f0860$%dae@samsung.com> @ 2013-10-31 23:06 ` Jingoo Han 2013-10-31 23:11 ` Tomasz Figa 0 siblings, 1 reply; 6+ messages in thread From: Jingoo Han @ 2013-10-31 23:06 UTC (permalink / raw) To: 'Inki Dae', 'Sean Paul', dri-devel Cc: 'Tomi Valkeinen', 'Jean-Christophe PLAGNIOL-VILLARD', linux-fbdev, linux-samsung-soc, airlied, tomasz.figa, marcheu, 'Jingoo Han' On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > CCing Jingoo, > > Is that ok to remove eDP driver from video/exynos? Isn't this driver really > used by Linux framebuffer driver, s3c-fb.c? +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, linux-fbdev list, linux-samsung-soc list Yes, it is used by s3c-fb.c. > > Of course, now s3c-fb driver is dead code because this driver doesn't > support device tree yet but we would need more reviews and discussions about > moving this driver into drm side. Let's watch new rules for device tree > bindings of DRM world. So I'd not like to merge this driver yet. 's3c-fb' driver is still used for other mass products projects. Just, device tree support patch is not yet submitted. Sean Paul, When moving the driver, notify related Maintainers of that driver. Please use 'scripts/get_maintainer.pl' next time. Best regards, Jingoo Han ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ 2013-10-31 23:06 ` [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ Jingoo Han @ 2013-10-31 23:11 ` Tomasz Figa 2013-10-31 23:23 ` Jingoo Han 0 siblings, 1 reply; 6+ messages in thread From: Tomasz Figa @ 2013-10-31 23:11 UTC (permalink / raw) To: Jingoo Han Cc: 'Inki Dae', 'Sean Paul', dri-devel, 'Tomi Valkeinen', 'Jean-Christophe PLAGNIOL-VILLARD', linux-fbdev, linux-samsung-soc, airlied, marcheu On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > CCing Jingoo, > > > > Is that ok to remove eDP driver from video/exynos? Isn't this driver > > really used by Linux framebuffer driver, s3c-fb.c? > > +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, > linux-fbdev list, linux-samsung-soc list > > Yes, it is used by s3c-fb.c. > > > Of course, now s3c-fb driver is dead code because this driver doesn't > > support device tree yet but we would need more reviews and discussions > > about moving this driver into drm side. Let's watch new rules for > > device tree bindings of DRM world. So I'd not like to merge this > > driver yet. > 's3c-fb' driver is still used for other mass products projects. > Just, device tree support patch is not yet submitted. Current in-tree users of s3c-fb drivers are s3c2443, non-DT s3c64xx and all s5p* SoCs. It is not used on Exynos SoCs anymore. As for Exynos DP driver, what SoCs does it support? If only Exynos (as the name suggests) then there is no point in keeping it at video/exynos and making it a part of Exynos DRM driver seems reasonable to me. Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ 2013-10-31 23:11 ` Tomasz Figa @ 2013-10-31 23:23 ` Jingoo Han 2013-10-31 23:27 ` Tomasz Figa 0 siblings, 1 reply; 6+ messages in thread From: Jingoo Han @ 2013-10-31 23:23 UTC (permalink / raw) To: 'Tomasz Figa' Cc: 'Inki Dae', 'Sean Paul', dri-devel, 'Tomi Valkeinen', 'Jean-Christophe PLAGNIOL-VILLARD', linux-fbdev, linux-samsung-soc, airlied, marcheu, 'Jingoo Han' On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > > CCing Jingoo, > > > > > > Is that ok to remove eDP driver from video/exynos? Isn't this driver > > > really used by Linux framebuffer driver, s3c-fb.c? > > > > +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, > > linux-fbdev list, linux-samsung-soc list > > > > Yes, it is used by s3c-fb.c. > > > > > Of course, now s3c-fb driver is dead code because this driver doesn't > > > support device tree yet but we would need more reviews and discussions > > > about moving this driver into drm side. Let's watch new rules for > > > device tree bindings of DRM world. So I'd not like to merge this > > > driver yet. > > 's3c-fb' driver is still used for other mass products projects. > > Just, device tree support patch is not yet submitted. > > Current in-tree users of s3c-fb drivers are s3c2443, non-DT s3c64xx and > all s5p* SoCs. It is not used on Exynos SoCs anymore. Hi Tomasz Figa, Some mass product projects using Exynos5250 and etc, use s3c-fb driver and dp driver. Also, these projects are still using Framebuffer, not DRM. > > As for Exynos DP driver, what SoCs does it support? If only Exynos (as the > name suggests) then there is no point in keeping it at video/exynos and > making it a part of Exynos DRM driver seems reasonable to me. However, when considering only mainline kernel, I have no strong objection. As you know, many Linux kernel based OS projects using Exynos, are using DRM, not Framebuffer. Also, if moving DP driver to DRM, MAINTAINERS entry for Exynos DP driver should be updated, too. Best regards, Jingoo Han ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ 2013-10-31 23:23 ` Jingoo Han @ 2013-10-31 23:27 ` Tomasz Figa 2013-10-31 23:55 ` Jingoo Han 0 siblings, 1 reply; 6+ messages in thread From: Tomasz Figa @ 2013-10-31 23:27 UTC (permalink / raw) To: Jingoo Han Cc: 'Inki Dae', 'Sean Paul', dri-devel, 'Tomi Valkeinen', 'Jean-Christophe PLAGNIOL-VILLARD', linux-fbdev, linux-samsung-soc, airlied, marcheu On Friday 01 of November 2013 08:23:59 Jingoo Han wrote: > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > > > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > > > CCing Jingoo, > > > > > > > > Is that ok to remove eDP driver from video/exynos? Isn't this > > > > driver > > > > really used by Linux framebuffer driver, s3c-fb.c? > > > > > > +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, > > > > > > linux-fbdev list, linux-samsung-soc list > > > > > > Yes, it is used by s3c-fb.c. > > > > > > > Of course, now s3c-fb driver is dead code because this driver > > > > doesn't > > > > support device tree yet but we would need more reviews and > > > > discussions > > > > about moving this driver into drm side. Let's watch new rules for > > > > device tree bindings of DRM world. So I'd not like to merge this > > > > driver yet. > > > > > > 's3c-fb' driver is still used for other mass products projects. > > > Just, device tree support patch is not yet submitted. > > > > Current in-tree users of s3c-fb drivers are s3c2443, non-DT s3c64xx > > and > > all s5p* SoCs. It is not used on Exynos SoCs anymore. > > Hi Tomasz Figa, Just Tomasz. ;) > Some mass product projects using Exynos5250 and etc, use s3c-fb driver > and dp driver. Also, these projects are still using Framebuffer, not > DRM. Well, those are based on vendor trees anyway, so do not really affect mainline kernel. > > As for Exynos DP driver, what SoCs does it support? If only Exynos (as > > the name suggests) then there is no point in keeping it at > > video/exynos and making it a part of Exynos DRM driver seems > > reasonable to me. > > However, when considering only mainline kernel, I have no strong > objection. As you know, many Linux kernel based OS projects using > Exynos, are using DRM, not Framebuffer. Generally, fbdev is strongly discouraged in any new systems and DRM is the way to go, so I don't think we should ever want to bring s3c-fb support back to Exynos platforms. > > Also, if moving DP driver to DRM, MAINTAINERS entry for Exynos DP driver > should be updated, too. That's correct. Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ 2013-10-31 23:27 ` Tomasz Figa @ 2013-10-31 23:55 ` Jingoo Han 2013-11-01 0:01 ` Tomasz Figa 0 siblings, 1 reply; 6+ messages in thread From: Jingoo Han @ 2013-10-31 23:55 UTC (permalink / raw) To: 'Tomasz Figa' Cc: 'Inki Dae', 'Sean Paul', dri-devel, 'Tomi Valkeinen', 'Jean-Christophe PLAGNIOL-VILLARD', linux-fbdev, linux-samsung-soc, airlied, marcheu, 'Jingoo Han' On Friday, November 01, 2013 8:27 AM, Tomasz Figa wrote: > On Friday 01 of November 2013 08:23:59 Jingoo Han wrote: > > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > > > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > > > > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > > > > CCing Jingoo, > > > > > > > > > > Is that ok to remove eDP driver from video/exynos? Isn't this > > > > > driver > > > > > really used by Linux framebuffer driver, s3c-fb.c? > > > > > > > > +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, > > > > > > > > linux-fbdev list, linux-samsung-soc list > > > > > > > > Yes, it is used by s3c-fb.c. > > > > > > > > > Of course, now s3c-fb driver is dead code because this driver > > > > > doesn't > > > > > support device tree yet but we would need more reviews and > > > > > discussions > > > > > about moving this driver into drm side. Let's watch new rules for > > > > > device tree bindings of DRM world. So I'd not like to merge this > > > > > driver yet. > > > > > > > > 's3c-fb' driver is still used for other mass products projects. > > > > Just, device tree support patch is not yet submitted. > > > > > > Current in-tree users of s3c-fb drivers are s3c2443, non-DT s3c64xx > > > and > > > all s5p* SoCs. It is not used on Exynos SoCs anymore. > > > > Hi Tomasz Figa, > > Just Tomasz. ;) Hi Tomasz, :-) > > > Some mass product projects using Exynos5250 and etc, use s3c-fb driver > > and dp driver. Also, these projects are still using Framebuffer, not > > DRM. > > Well, those are based on vendor trees anyway, so do not really affect > mainline kernel. OK, I see. > > > > As for Exynos DP driver, what SoCs does it support? If only Exynos (as > > > the name suggests) then there is no point in keeping it at > > > video/exynos and making it a part of Exynos DRM driver seems > > > reasonable to me. > > > > However, when considering only mainline kernel, I have no strong > > objection. As you know, many Linux kernel based OS projects using > > Exynos, are using DRM, not Framebuffer. > > Generally, fbdev is strongly discouraged in any new systems and DRM is the > way to go, so I don't think we should ever want to bring s3c-fb support > back to Exynos platforms. Yes, you're right. Personally, I think that all Exynos platforms should go into DRM, not FB. One more thing, then how about moving Exynos MIPI to DRM side? Is there any plan on Exynos MIPI? Best regards, Jingoo Han > > > > > Also, if moving DP driver to DRM, MAINTAINERS entry for Exynos DP driver > > should be updated, too. > > That's correct. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ 2013-10-31 23:55 ` Jingoo Han @ 2013-11-01 0:01 ` Tomasz Figa 0 siblings, 0 replies; 6+ messages in thread From: Tomasz Figa @ 2013-11-01 0:01 UTC (permalink / raw) To: Jingoo Han Cc: linux-fbdev, linux-samsung-soc, dri-devel, 'Tomi Valkeinen', marcheu, 'Jean-Christophe PLAGNIOL-VILLARD' On Friday 01 of November 2013 08:55:12 Jingoo Han wrote: > On Friday, November 01, 2013 8:27 AM, Tomasz Figa wrote: > > On Friday 01 of November 2013 08:23:59 Jingoo Han wrote: > > > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > > > > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > > > > > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > > > > > CCing Jingoo, > > > > > > > > > > > > Is that ok to remove eDP driver from video/exynos? Isn't this > > > > > > driver > > > > > > really used by Linux framebuffer driver, s3c-fb.c? > > > > > > > > > > +cc Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, > > > > > > > > > > linux-fbdev list, linux-samsung-soc list > > > > > > > > > > Yes, it is used by s3c-fb.c. > > > > > > > > > > > Of course, now s3c-fb driver is dead code because this driver > > > > > > doesn't > > > > > > support device tree yet but we would need more reviews and > > > > > > discussions > > > > > > about moving this driver into drm side. Let's watch new rules > > > > > > for > > > > > > device tree bindings of DRM world. So I'd not like to merge > > > > > > this > > > > > > driver yet. > > > > > > > > > > 's3c-fb' driver is still used for other mass products projects. > > > > > Just, device tree support patch is not yet submitted. > > > > > > > > Current in-tree users of s3c-fb drivers are s3c2443, non-DT > > > > s3c64xx > > > > and > > > > all s5p* SoCs. It is not used on Exynos SoCs anymore. > > > > > > Hi Tomasz Figa, > > > > Just Tomasz. ;) > > Hi Tomasz, :-) > > > > Some mass product projects using Exynos5250 and etc, use s3c-fb > > > driver > > > and dp driver. Also, these projects are still using Framebuffer, not > > > DRM. > > > > Well, those are based on vendor trees anyway, so do not really affect > > mainline kernel. > > OK, I see. > > > > > As for Exynos DP driver, what SoCs does it support? If only Exynos > > > > (as > > > > the name suggests) then there is no point in keeping it at > > > > video/exynos and making it a part of Exynos DRM driver seems > > > > reasonable to me. > > > > > > However, when considering only mainline kernel, I have no strong > > > objection. As you know, many Linux kernel based OS projects using > > > Exynos, are using DRM, not Framebuffer. > > > > Generally, fbdev is strongly discouraged in any new systems and DRM is > > the way to go, so I don't think we should ever want to bring s3c-fb > > support back to Exynos platforms. > > Yes, you're right. > Personally, I think that all Exynos platforms should go into DRM, not > FB. > > One more thing, then how about moving Exynos MIPI to DRM side? > Is there any plan on Exynos MIPI? Well, it will eventually have to be moved somewhere else than it is, but I believe this will have to wait for Common Display Framework. This is because the case of MIPI DSI is slightly different from DisplayPort, since it is not an enumerable/auto-configurable interface and requires dedicated panel drivers and static data provided by board designers (in DT for example). Handling of such things in a generic way will be done by CDF. Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-01 0:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
[not found] ` <1383063198-10526-22-git-send-email-seanpaul@chromium.org>
[not found] ` <031801ced626$7cca5820$765f0860$%dae@samsung.com>
2013-10-31 23:06 ` [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ Jingoo Han
2013-10-31 23:11 ` Tomasz Figa
2013-10-31 23:23 ` Jingoo Han
2013-10-31 23:27 ` Tomasz Figa
2013-10-31 23:55 ` Jingoo Han
2013-11-01 0:01 ` Tomasz Figa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).