Re: [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

On Thursday, August 02, 2018 01:28:38 PM Hans de Goede wrote:
> Hi Bartlomiej,
> 
> After backporting the deferred fbcon takeover patches to the 4.18
> kernel for the upcoming Fedora 29 release, Fedora QA found a serious
> bug caused by the fbcon takeover support.
> 
> When using classic (non EFI) boot on x86 and thus using vgacon, dummycon
> is not used, so the deferred takeover never happens as that depends on
> dummycon being the vt-console driver until the takeover happens.
> 
> This is fixed by the 2nd patch in this set, futher testing has shown that
> that breaks the build when fb.o is a module, because of the conswitchp
> symbol not being exported.  This made me realize that I never intended for
> deferred fbcon takeover to be possible when fbdev+fbcon are being build as
> a module (*), so instead of exporting yet more symbols, the first patch is
> a preparation patch which only allows deferred fbcon takeover when builtin.
> 
> The third patch is a cleanup patch unexporting the dummycon_[un]register_output
> symbols since those now no longer need to be exported.
> 
> At least patches 1 and 2 should be added to your tree for merging into 4.19,
> patch 3 can go in in the 4.20 cycle if you prefer delaying it till then.

Patches 1-3 queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics