From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout04.his.huawei.com (canpmsgout04.his.huawei.com [113.46.200.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7998F38BF83 for ; Thu, 19 Mar 2026 02:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773886952; cv=none; b=Fgz8tilp+bMdWoIISnAfCDtWDV16NSck8lfCfomg7abO9P4vE8ddo3Y7Z8yyMzCAXiyuULH5yZE9XwOdHdi8UKY0dmFlXFYGb6nVfm91M/cPfOnWeDPsfv+HPDToN34KjXW3SKDS9NW/7ZK/SLZ+tUSytKiJzDne7RwxM+T5YeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773886952; c=relaxed/simple; bh=hQ5PpVPDBZWawyM0ayJhr08ojkIkFi9vC7x50LOqyys=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DqXYXISRJiYdiBHjkXX58GWeOX+UpnFlKW8Ol+xTc0W6WyobRAf4bjKRWlFBrSUvzggaf8FBzWWFMhCXFrTcvbttgprpIlW4Q5wjNqMygauNZxP69ZyF250GUU08lxJjdY9BXUX1Ww1G89mxtrPBdfGbkWQgvkWzTz9AtXSPsv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=tG63bQvf; arc=none smtp.client-ip=113.46.200.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="tG63bQvf" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=93LCmuldWr4tLH+BtbdYHpMx6zo+NrUbQf0xHNbPV1Y=; b=tG63bQvfFvVkNAGGiCoRwP/MqBoPqUK6+S7qg2/5tPZ9+0VBBLgZGeDEYAAJijAWBmzLSNYub tcXw1iyXwXnT+hGBdkPmoRey3jRCufYovSSLLFvaGBHb6n5eTZWSksVA+XV38frXSlKeQ56HI3c xmHFN5IaKymb57kG7dlqwE0= Received: from mail.maildlp.com (unknown [172.19.163.104]) by canpmsgout04.his.huawei.com (SkyGuard) with ESMTPS id 4fbq8M28wQz1prn3; Thu, 19 Mar 2026 10:17:07 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 872414056A; Thu, 19 Mar 2026 10:22:09 +0800 (CST) Received: from [10.174.179.11] (10.174.179.11) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 19 Mar 2026 10:22:08 +0800 Message-ID: <17605e19-065c-4b71-abb2-a9c9a7b9ddc6@huawei.com> Date: Thu, 19 Mar 2026 10:22:08 +0800 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] video: fbdev: matroxfb: remove dead code and set but not used variable To: Andy Shevchenko , Sam Ravnborg , Helge Deller CC: , , References: <20200403021609.20968-1-yanaijie@huawei.com> <20200408101852.GC20795@ravnborg.org> From: Jason Yan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To dggpemf500002.china.huawei.com (7.185.36.57) 在 2026/3/18 15:45, Andy Shevchenko 写道: > On Wed, Apr 08, 2020 at 10:18:52AM +0000, Sam Ravnborg wrote: >> On Fri, Apr 03, 2020 at 10:16:09AM +0800, Jason Yan wrote: >>> Fix the following gcc warning: >>> >>> drivers/video/fbdev/matrox/g450_pll.c:336:15: warning: variable >>> ‘pixel_vco’ set but not used [-Wunused-but-set-variable] >>> unsigned int pixel_vco; >>> ^~~~~~~~~ >>> >>> Reported-by: Hulk Robot >>> Signed-off-by: Jason Yan >> >> Thanks, committed and pushed to drm-misc-next. >> The fix will show up in upstream kernel at the next >> merge window. > > The most of the patches from so called Hulk Robot appeared to be controversial. > > First of all, even so called "dead code" may have side effects on the registers > in HW which may lead to other issues. Second, the mentioned dead code elimination > patch doesn't improve anything as now the dead code is 'mnp' variable (that's how > I got into that, I still have a build error). Sorry, I do not understand what side effects this may cause. Would you please explain it in detail? Thanks, Jason > > That said, for the starter I suggest to revert this change. After one need go > carefully through code to understand if it's exactly the case and what to do with > 'mnp' which involves some IO. > > +Cc: current fbdev maintainers >