From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 26 Jul 2012 11:20:44 +0000 Subject: Re: [PATCH v2 4/4] fbdev: sh_mobile_lcdc: use dma_mmap_coherent if available Message-Id: <1820152.JumtPU1V17@avalon> List-Id: References: <1343301191-26001-1-git-send-email-hdk@igel.co.jp> <1343301191-26001-5-git-send-email-hdk@igel.co.jp> In-Reply-To: <1343301191-26001-5-git-send-email-hdk@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hideki EIRAKU Cc: alsa-devel@alsa-project.org, Katsuya MATSUBARA , linux-fbdev@vger.kernel.org, Russell King , linux-media@vger.kernel.org, Pawel Osciak , Florian Tobias Schandinat , Takashi Iwai , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Kyungmin Park , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Hi Eiraku-san, On Thursday 26 July 2012 20:13:11 Hideki EIRAKU wrote: > fb_mmap() implemented in fbmem.c uses smem_start as the physical > address of the frame buffer. In the sh_mobile_lcdc driver, the > smem_start is a dma_addr_t that is not a physical address when IOMMU is > enabled. dma_mmap_coherent() maps the address correctly. It is > available on ARM platforms. > > Signed-off-by: Hideki EIRAKU Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart