* [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h @ 2017-02-17 14:41 ` Arnd Bergmann 2017-02-20 12:52 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Arnd Bergmann @ 2017-02-17 14:41 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Tomi Valkeinen Cc: Arnd Bergmann, Jyri Sarha, LABBE Corentin, linux-fbdev, linux-kernel Changing this driver to the gpiod API requires the use of the new-style header, depending on the configuration: drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe': drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function) Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/fbdev/ssd1307fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 5c87ae4bac6a..bd017b57c47f 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -9,6 +9,7 @@ #include <linux/backlight.h> #include <linux/delay.h> #include <linux/fb.h> +#include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/kernel.h> #include <linux/module.h> -- 2.9.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h 2017-02-17 14:41 ` [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h Arnd Bergmann @ 2017-02-20 12:52 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-02-20 12:52 UTC (permalink / raw) To: Arnd Bergmann Cc: Tomi Valkeinen, Jyri Sarha, LABBE Corentin, linux-fbdev, linux-kernel Hi, On Friday, February 17, 2017 03:41:42 PM Arnd Bergmann wrote: > Changing this driver to the gpiod API requires the use of the > new-style header, depending on the configuration: > > drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe': > drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function) > > Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks for fixing this. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-20 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170217144238epcas4p1bb3d59ce932e9ce12e4078268538933e@epcas4p1.samsung.com>
2017-02-17 14:41 ` [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h Arnd Bergmann
2017-02-20 12:52 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).