From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 31 Jul 2018 11:04:14 +0000 Subject: Re: [PATCH] media: omap2: omapfb: fix bugon.cocci warnings Message-Id: <1852918.sFt5Xj4oDG@amdc3058> List-Id: References: <201807260144.q4WK2PMA%fengguang.wu@intel.com> <20180725175700.GA82595@lkp-sb05.lkp.intel.com> In-Reply-To: <20180725175700.GA82595@lkp-sb05.lkp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kbuild test robot Cc: Mauro Carvalho Chehab , kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Tomi Valkeinen , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote: > From: kbuild test robot > > drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. > Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) > > Use BUG_ON instead of a if condition followed by BUG. > > Semantic patch information: > This makes an effort to find cases where BUG() follows an if > condition on an expression and replaces the if condition and BUG() > with a BUG_ON having the conditional expression of the if statement > as argument. > > Generated by: scripts/coccinelle/misc/bugon.cocci > > Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") > Signed-off-by: kbuild test robot Patch queued for 4.19 (w/ "media"->"fbdev" fixup in the patch title), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics