From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Sun, 07 Oct 2012 13:38:33 +0000 Subject: Re: [PATCH 2/2 v6] of: add generic videomode description Message-Id: <1865954.iaNNHHSnLW@avalon> List-Id: References: <1349373560-11128-1-git-send-email-s.trumtrar@pengutronix.de> <506DDA94.1090702@wwwdotorg.org> <20121005155121.GA2053@pengutronix.de> In-Reply-To: <20121005155121.GA2053@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steffen Trumtrar Cc: Stephen Warren , devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-media@vger.kernel.org Hi Steffen, On Friday 05 October 2012 17:51:21 Steffen Trumtrar wrote: > On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: > > On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: > > > Get videomode from devicetree in a format appropriate for the > > > backend. drm_display_mode and fb_videomode are supported atm. > > > Uses the display signal timings from of_display_timings > > > > > > +++ b/drivers/of/of_videomode.c > > > > > > +int videomode_from_timing(struct display_timings *disp, struct > > > videomode *vm, > > > > > > + st = display_timings_get(disp, index); > > > + > > > + if (!st) { > > > > It's a little odd to leave a blank line between those two lines. > > Hm, well okay. That can be remedied > > > Only half of the code in this file seems OF-related; the routines to > > convert a timing to a videomode or drm display mode seem like they'd be > > useful outside device tree, so I wonder if putting them into > > of_videomode.c is the correct thing to do. Still, it's probably not a > > big deal. > > I am not sure, what the appropriate way to do this is. I can split it up > (again). I think it would make sense to move them to their respective subsystems. -- Regards, Laurent Pinchart