From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Jaya Kumar <jayakumar.lkml@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Eric Miao <eric.miao@marvell.com>,
Krzysztof Helt <krzysztof.h1@poczta.fm>,
linux-fbdev-devel@lists.sourceforge.net,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [RFC 2.6.27 2/2] mach-pxa: add AM300 platform driver
Date: Tue, 23 Dec 2008 10:24:37 +0100 [thread overview]
Message-ID: <18768.44629.937505.213868@ipc1.ka-ro> (raw)
In-Reply-To: <f17812d70812230047g54cae195g8cf6297783d2602c@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
Hi,
Eric Miao writes:
> On Sun, Dec 21, 2008 at 6:59 PM, Jaya Kumar <jayakumar.lkml@gmail.com> wrote:
> > This patch adds support for the AM300 platform driver.
> >
>
> Patch looks good, I feel I'm nit-picking. Anyway , see my comments below:
>
[...]
> > +static int am300_wait_for_rdy(struct broadsheetfb_par *par)
> > +{
> > + unsigned long flags;
> > + DEFINE_WAIT(wait);
> > +
> > + spin_lock_irqsave(par->lock, flags);
> > + while (!gpio_get_value(RDY_GPIO_PIN)) {
> > + prepare_to_wait(&par->waitq, &wait, TASK_INTERRUPTIBLE);
^^^^^^^^^^^^^
This should be TASK_UNINTERRUPTIBLE, or the case of an interrupted
wait need to be handled in some way!
> wait_event() might be the perfect choice for the above case, unless your
>
... which would also fix the above bug.
Lothar Wa���mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra���e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch���ftsf���hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
[-- Attachment #2: Type: text/plain, Size: 271 bytes --]
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-12-23 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 10:59 [RFC 2.6.27 2/2] mach-pxa: add AM300 platform driver Jaya Kumar
2008-12-23 8:47 ` Eric Miao
2008-12-23 9:24 ` Lothar Waßmann [this message]
2008-12-24 5:25 ` Jaya Kumar
-- strict thread matches above, loose matches on Subject: below --
2008-12-25 12:51 [RFC 2.6.27 1/2] fbdev: add E-Ink Broadsheet controller support v2 Jaya Kumar
2008-12-25 12:51 ` [RFC 2.6.27 2/2] mach-pxa: add AM300 platform driver Jaya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18768.44629.937505.213868@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=eric.miao@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jayakumar.lkml@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).