Re: [RFC 2.6.27 1/2] fbdev: add E-Ink Broadsheet controller support v2

["Lothar Waßmann" <LW@KARO-electronics.de>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

Jaya Kumar writes:
> +static void broadsheet_send_cmdargs(struct broadsheetfb_par *par, u16 cmd,
> +					int argc, u16 *argv)
> +{
> +	int i;
> +
> +	par->board->wait_for_rdy(par);
> +
You should probably check the return value of wait_for_rdy() and
distinguish between:
  == 0 => the GPIO was not found asserted within the timeout period
  < 0  => the wait was interrupted due to a signal
  > 0  => OK
Only in the last case the RDY_GPIO_PIN actually signalled a READY
condition. In the other two cases you might not expect the hardware to
do what you actually want it to do.

Otherwise you should probably better use the plain wait_event()
instead of wait_event_interruptible_timeout() in the wait_for_rdy()
function which only returns when the expected condition has been
found (but may block indefinitely when the condition never occurs).



Lothar Wa���mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra���e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch���ftsf���hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________


[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel