* [PATCH 0/2] constify usb_device_id.
@ 2017-08-06 7:21 Arvind Yadav
2017-08-06 7:21 ` [PATCH 1/2] video: fbdev: smscufx: " Arvind Yadav
2017-08-06 7:21 ` [PATCH 2/2] video: fbdev: udlfb: " Arvind Yadav
0 siblings, 2 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-08-06 7:21 UTC (permalink / raw)
To: steve.glendinning, b.zolnierkie, bernie; +Cc: linux-fbdev, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Arvind Yadav (2):
[PATCH 1/2] video: fbdev: smscufx: constify usb_device_id.
[PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.
drivers/video/fbdev/smscufx.c | 2 +-
drivers/video/fbdev/udlfb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] video: fbdev: smscufx: constify usb_device_id.
2017-08-06 7:21 [PATCH 0/2] constify usb_device_id Arvind Yadav
@ 2017-08-06 7:21 ` Arvind Yadav
2017-08-21 13:56 ` Bartlomiej Zolnierkiewicz
2017-08-06 7:21 ` [PATCH 2/2] video: fbdev: udlfb: " Arvind Yadav
1 sibling, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-08-06 7:21 UTC (permalink / raw)
To: steve.glendinning, b.zolnierkie, bernie; +Cc: linux-fbdev, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/smscufx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
index 449fcea..2275e80 100644
--- a/drivers/video/fbdev/smscufx.c
+++ b/drivers/video/fbdev/smscufx.c
@@ -122,7 +122,7 @@ static const u32 smscufx_info_flags = FBINFO_DEFAULT | FBINFO_READS_FAST |
FBINFO_VIRTFB | FBINFO_HWACCEL_IMAGEBLIT | FBINFO_HWACCEL_FILLRECT |
FBINFO_HWACCEL_COPYAREA | FBINFO_MISC_ALWAYS_SETPAR;
-static struct usb_device_id id_table[] = {
+static const struct usb_device_id id_table[] = {
{USB_DEVICE(0x0424, 0x9d00),},
{USB_DEVICE(0x0424, 0x9d01),},
{},
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] video: fbdev: smscufx: constify usb_device_id.
2017-08-06 7:21 ` [PATCH 1/2] video: fbdev: smscufx: " Arvind Yadav
@ 2017-08-21 13:56 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-21 13:56 UTC (permalink / raw)
To: Arvind Yadav; +Cc: steve.glendinning, bernie, linux-fbdev, linux-kernel
On Sunday, August 06, 2017 12:39:27 PM Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.
2017-08-06 7:21 [PATCH 0/2] constify usb_device_id Arvind Yadav
2017-08-06 7:21 ` [PATCH 1/2] video: fbdev: smscufx: " Arvind Yadav
@ 2017-08-06 7:21 ` Arvind Yadav
2017-08-21 13:59 ` Bartlomiej Zolnierkiewicz
1 sibling, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-08-06 7:21 UTC (permalink / raw)
To: steve.glendinning, b.zolnierkie, bernie; +Cc: linux-fbdev, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/udlfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 05ef657..d836e6e 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -54,7 +54,7 @@ static const u32 udlfb_info_flags = FBINFO_DEFAULT | FBINFO_READS_FAST |
* which is compatible with all known USB 2.0 era graphics chips and firmware,
* but allows DisplayLink to increment those for any future incompatible chips
*/
-static struct usb_device_id id_table[] = {
+static const struct usb_device_id id_table[] = {
{.idVendor = 0x17e9,
.bInterfaceClass = 0xff,
.bInterfaceSubClass = 0x00,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.
2017-08-06 7:21 ` [PATCH 2/2] video: fbdev: udlfb: " Arvind Yadav
@ 2017-08-21 13:59 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-21 13:59 UTC (permalink / raw)
To: Arvind Yadav; +Cc: steve.glendinning, bernie, linux-fbdev, linux-kernel
On Sunday, August 06, 2017 12:39:28 PM Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-21 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-06 7:21 [PATCH 0/2] constify usb_device_id Arvind Yadav
2017-08-06 7:21 ` [PATCH 1/2] video: fbdev: smscufx: " Arvind Yadav
2017-08-21 13:56 ` Bartlomiej Zolnierkiewicz
2017-08-06 7:21 ` [PATCH 2/2] video: fbdev: udlfb: " Arvind Yadav
2017-08-21 13:59 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).