From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Fri, 10 Nov 2017 15:33:38 +0000 Subject: Re: [PATCH] video: fbdev: Convert timers to use timer_setup() Message-Id: <1971713.1U12EbtSlg@amdc3058> List-Id: References: <15752127.NCT7iFVURk@amdc3058> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook Cc: linux-fbdev@vger.kernel.org, David Lechner , "Gustavo A. R. Silva" , LKML , Maling list - DRI developers , Hans de Goede , Tomi Valkeinen , Daniel Vetter , linux-omap@vger.kernel.org, Jean Delvare On Thursday, November 09, 2017 10:40:13 AM Kees Cook wrote: > On Thu, Nov 9, 2017 at 9:08 AM, Bartlomiej Zolnierkiewicz [...] > > [ Please compile these timer changes with PXA3XX_GCU_DEBUG and > > PXA3XX_GCU_DEBUG_TIMER defined. ] > > Hm, these appear to be manual knobs? What do you think about wiring > these up to a Kconfig so build tests for things like "make > allmodconfig" would enable it? This would allow for much greater build > coverage. This is a good idea, care to send a patch? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics