From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98576C38147 for ; Wed, 18 Jan 2023 14:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbjAROEq (ORCPT ); Wed, 18 Jan 2023 09:04:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbjARODs (ORCPT ); Wed, 18 Jan 2023 09:03:48 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E80B3252A8 for ; Wed, 18 Jan 2023 05:40:03 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id j34-20020a05600c1c2200b003da1b054057so1413576wms.5 for ; Wed, 18 Jan 2023 05:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jjc4VCpZNQP556V0c7PmfHBKoB04p5vvZzElOaTdSEg=; b=XV8+LO/0KQENBbmt/brfX4pIAJEO8/CsQI3T5uXentjRlVKmeZ+Lez9yC3jGyXpH7S O98BAdGi3PF7LJ19YIl6AltWzzY6KDINRRbLEzyK+oXZ9peDaAEL8qewhOQ5TBIMLNvL cY17/rRQddElbgeeOmueS/vt+DJnU+0yT0Y5fJIBcsd4bmthmE91Bpa3asUxaI0H2P46 Mp8gZ7WZCSG9TzLhYf8ZHbTkrYNPiMIBqWpdtq91zi70bdUI7YEzQTGCw3sLxg3/IIHp 8njKqiHGKyTlN53ZXhE0CBTE4zcsEllgVNwM4Se39fxtfRUxj6J3uOLbS0wsXRYXJSjH daRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jjc4VCpZNQP556V0c7PmfHBKoB04p5vvZzElOaTdSEg=; b=C0erQNzD7H6qGOYJPCVkxyJY2z+tM7MWrIuNFpQo2BOCoeMgLBj7WdCeA0bihGIku3 5COhpCj5VcFHXe467hZt2FnCzPP4JSob7Xmau3kLXve7XQfGAKEdkiH4UJg68KKxcvSH cP1nZp94sj/i5goZZmSkQWclUAuNDSQqFGkQpQlnLOcJwISnlS0kGeCO2R/QGUHDQKTN A4RzUfeqQbyBv9bkbCrM9SHagsP5gK84MSLEai7U1ps+XUs1OIZPUkmCx0I1XNviRPfo QIs1X4v93XCMWKgcvj1hol6tP48zi2lE2A9MdvAxfwuExvsD1ZipjO26W4B5C2JXGWKw bQzg== X-Gm-Message-State: AFqh2kr88VJ8dAKNMD31T6FZOd3gj6bI23Ea1I6AS8EwOx3ZEGL34EKl 1FxQCrllyXDhcs0JQk5Yy5tPDA== X-Google-Smtp-Source: AMrXdXsYqqOpahJDdUdyjMPCRZYkQl34osNeO69nPzrNQAGp4jHjFNBdqZh1Sg7dDQ6W3H8ez7AfOQ== X-Received: by 2002:a05:600c:181b:b0:3da:ff1f:e8d3 with SMTP id n27-20020a05600c181b00b003daff1fe8d3mr6684165wmp.15.1674049202461; Wed, 18 Jan 2023 05:40:02 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c468f00b003d9b87296a9sm2024751wmo.25.2023.01.18.05.40.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 05:40:02 -0800 (PST) Message-ID: <1a8c006d-c9b9-9fd0-147e-7e511cb236fe@linaro.org> Date: Wed, 18 Jan 2023 14:40:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v6 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight Content-Language: en-US To: Jianhua Lu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20230118131002.15453-1-lujianhua000@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230118131002.15453-1-lujianhua000@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 18/01/2023 14:10, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Remove "items" between "compatible" and "const: kinetic,ktz8866" > - Change "additionalProperties" to "unevaluatedProperties" > > Changes in v3: > - Add Krzysztof's R-b > > Changes in v4: > - Drop Krzysztof's R-b > - Add some new properties > > Changes in v5: > - Add missing enum under property description. > - Rename uncorrect properties. > > Changes in v6: > - Correct wrong property suffix and description. > > .../leds/backlight/kinetic,ktz8866.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > new file mode 100644 > index 000000000000..ca0deba14523 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kinetic Technologies KTZ8866 backlight > + > +maintainers: > + - Jianhua Lu > + > +description: | > + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight > + with dual lcd bias power. > + https://www.kinet-ic.com/ktz8866/ > + > +allOf: > + - $ref: common.yaml# > + > +properties: > + compatible: > + const: kinetic,ktz8866 > + > + current-num-sinks: > + description: Number of LED current sinks. > + enum: [1, 2, 3, 4, 5, 6] > + > + current-ramping-time-ms: > + description: LED current ramping time in milliseconds. > + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640] > + > + led-ramping-time-ms: > + description: | > + LED on/off ramping time in milliseconds, note that the case 0 will be mapped > + to 512μs because ktz8866 can't ramp faster than it. Aren't you just missing supplies here and their ramp up time? > + enum: [0, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384] > + > + enable-lcd-bias: > + description: Set if we want to output bias power supply for LCD. Is it a generic property? I don't see any other users, so this looks device specific thus needs vendor prefix. This applies to all of the properties. They might be generic or might not, I don't know the backlight hardware that much. > + type: boolean > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + backlight { > + compatible = "kinetic,ktz8866"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&bl_en_default>; > + > + current-num-sinks = <5>; > + current-ramping-time-ms = <128>; > + led-ramping-time-ms = <1>; > + enable-lcd-bias; > + }; Best regards, Krzysztof