Re: radeonfb and 16bit color problem

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

>Any ideas would be helpful.  I tried looking at the code myself, but I'm
>still quite new to the framebuffer code.  However, this part looked kind
>of strange to me:
>
>   /* For 565, the green component is mixed one order below */
>   if (rinfo->depth == 16) {
>      OUTREG(PALETTE_INDEX, pindex>>1);
>      OUTREG(PALETTE_DATA, (rinfo->palette[regno>>1].red << 16) |
>             (green << 8) | (rinfo->palette[regno>>1].blue));
>      green = rinfo->palette[regno<<1].green;
>   }
>
>
>BTW, I have a Radeon 8500 (QL).

I wrote that part and it works just fine on my powerbook... at least with
the radeonfb version that is in my tree, but I don't think it differs
from the official one in this regard. You can try making sure it's properly
setting 32 palette entries for green when using that mode.

Ben.




-------------------------------------------------------
Sponsored by:
ThinkGeek at http://www.ThinkGeek.com/