2.5 offb breakage

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

Hi !

I've investigated a bit why offb dies on boot with current 2.5.

It appears that dispsw is never set. You removed the code setting
it for the various bit depth. It seems the gen_set_disp() call
is supposed to do that instead.

However, gen_set_disp() only does it for var.bits_per_pixel == 24,
not for the other bit depths. In my case, offb boots at 8bpp, thus
dispsw is never set, causing fbcon_setup to die when trying to
call set_font(). That is without the accel in config. If I enable
accel support, then it dies later, in cfbimgblt, apparently due
to cfb_imageblit() beeing called with a NULL argument.

What is the correct fix ? Changing back offb to set dispsw or 
changing gen_set_disp() to set dispsw for all bit depth ?

Also, when code in fbcon_accel.c is calling things like
cfb_imageblit, it uses the "fb_info" field of structure
struct display. Where is this supposed to be initialized ?
It doesn't seem it's done in the drivers themselves (surely
not in offb).

Regards,
Ben.





-------------------------------------------------------
This sf.net email is sponsored by: Dice - The leading online job board
for high-tech professionals. Search and apply for tech jobs today!
http://seeker.dice.com/seeker.epl?rel_code=31