Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[Romain Dolbeau]

Chris Wilson wrote:

> Since I can't compile this driver on my architecture, I'm afraid I haven't 
> been able to test this patch at all.

This patch is relevant for 2.5.x only, and pm3fb can't compile
and work on 2.5.x. The FB API was changed, and FB drivers
need to be rewritten. As I never found a 2.5.x release that
would compile on my box (no x86 here), I didn't port pm3fb.

BTW, pm3fb should not be integrated in 2.5.x, it was submitted
only to 2.4.x and somehow found its way in 2.5.x. I don't
maintain pm3fb on 2.5.x, never has, and likely never will.

The proper fix for pm3fb in 2.5 is to delete it, at least
until someone else rewrite it or until 2.5.x can actually
compile and work on PowerPC and I can rewrite it myself.

-- 
romain



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [Linux-fbdev-devel] Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[Sven Luther]

On Mon, Nov 25, 2002 at 11:01:15AM +0100, Romain Dolbeau wrote:
> Chris Wilson wrote:
> 
> >Since I can't compile this driver on my architecture, I'm afraid I haven't 
> >been able to test this patch at all.
> 
> This patch is relevant for 2.5.x only, and pm3fb can't compile
> and work on 2.5.x. The FB API was changed, and FB drivers
> need to be rewritten. As I never found a 2.5.x release that
> would compile on my box (no x86 here), I didn't port pm3fb.
> 
> BTW, pm3fb should not be integrated in 2.5.x, it was submitted
> only to 2.4.x and somehow found its way in 2.5.x. I don't
> maintain pm3fb on 2.5.x, never has, and likely never will.
> 
> The proper fix for pm3fb in 2.5 is to delete it, at least
> until someone else rewrite it or until 2.5.x can actually
> compile and work on PowerPC and I can rewrite it myself.

I have plans for doing a full rewrite of pm3fb for 2.5, just not really
the times right now. I will do it before 2.6 (or 3.0 or whatever) is
released though. I have already done some work, just not filled in the
mode changes and other such. That said, it may be on the limit of my
NDA, which was supposed to be for XFree86 only (altough i guess the
current XFree86 code counts as available from other source though.

Friendly,

Sven Luther


-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en

Re: [Linux-fbdev-devel] Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[James Simmons]

> I have plans for doing a full rewrite of pm3fb for 2.5, just not really
> the times right now. I will do it before 2.6 (or 3.0 or whatever) is
> released though. I have already done some work, just not filled in the
> mode changes and other such. That said, it may be on the limit of my
> NDA, which was supposed to be for XFree86 only (altough i guess the
> current XFree86 code counts as available from other source though.

I just finished the low level driver api. It pretty much is set in stone. 
I might remove fg_color and bg_color in struct fb_image but that is a 
maybe and a small issue. I'm going to add software rotation in tonight. 
Then after that start cleaning up fbcon.c itself. You can grab the latest 
patch against 2.5.49 at

http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz

It works and several drivers work. 



-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en

Re: [Linux-fbdev-devel] Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[Sven Luther]

On Tue, Nov 26, 2002 at 11:38:04PM +0000, James Simmons wrote:
> 
> > I have plans for doing a full rewrite of pm3fb for 2.5, just not really
> > the times right now. I will do it before 2.6 (or 3.0 or whatever) is
> > released though. I have already done some work, just not filled in the
> > mode changes and other such. That said, it may be on the limit of my
> > NDA, which was supposed to be for XFree86 only (altough i guess the
> > current XFree86 code counts as available from other source though.
> 
> I just finished the low level driver api. It pretty much is set in stone. 
> I might remove fg_color and bg_color in struct fb_image but that is a 
> maybe and a small issue. I'm going to add software rotation in tonight. 
> Then after that start cleaning up fbcon.c itself. You can grab the latest 
> patch against 2.5.49 at
> 
> http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz
> 
> It works and several drivers work. 

Ok, thanks, i will give it a try.

But right now, i am doing some XFree86 work that need to be finished
before (or shortly after) the 4.3.0 feature freeze.

Friendly,

Sven Luther


-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en

Re: [Linux-fbdev-devel] Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[James Simmons]

> > http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz
> > 
> > It works and several drivers work. 
> 
> Ok, thanks, i will give it a try.
> 
> But right now, i am doing some XFree86 work that need to be finished
> before (or shortly after) the 4.3.0 feature freeze.

No problem. Thank you for your support.



-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en

Re: [Linux-fbdev-devel] Re: [PATCH] save_flags/cli in drivers/video/pm3fb.c

[James Simmons]

> The proper fix for pm3fb in 2.5 is to delete it, at least
> until someone else rewrite it or until 2.5.x can actually
> compile and work on PowerPC and I can rewrite it myself.

Does the ppc BK tree work?



-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en