From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [Linux-fbdev-devel] [PATCH] fix endian problem in color_imageblit Date: Sat, 21 Dec 2002 09:27:44 +0000 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <20021221092744.A23531@flint.arm.linux.org.uk> References: <1040442194.1294.9.camel@localhost.localdomain> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1040442194.1294.9.camel@localhost.localdomain>; from adaplas@pol.net on Sat, Dec 21, 2002 at 11:45:44AM +0800 List-Id: Cc: James Simmons , Paul Mackerras , Linux Kernel Mailing List , Linux Fbdev development list On Sat, Dec 21, 2002 at 11:45:44AM +0800, Antonino Daplas wrote: > The pseudopalette will only matter for truecolor and directcolor as the > rest of the visuals bypasses the pseudopalette. Typecasting to > "unsigned long" rather than "u32" is also safer (even for bpp16) since > in 64-bit machines, the drawing functions use fb_writeq instead of > fb_writel. Erm, what does the size of the drawing functions have to do with the size of the pseudo palette. The pseudo palette is only there to encode the pixel values for the 16 console colours. This means that a 64-bit pseudo palette would only be useful if you have a graphics card that supports > 32bpp, otherwise a 32-bit pseudo palette is perfectly adequate, even if you are using fb_writeq. (note that fbcon doesn't support > 32bpp, so we will only ever look at the first 32 bits, and having it be 64-bit would just be a needless waste of space imho.) -- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html