From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: Framebuffer updates. Date: Tue, 25 Mar 2003 19:20:43 +0100 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <20030325182043.GH30908@suse.de> References: Mime-Version: 1.0 Return-path: Received: from ns.virtualhost.dk ([195.184.98.160] helo=virtualhost.dk ident=mail) by sc8-sf-list1.sourceforge.net with esmtp (Cipher TLSv1:DES-CBC3-SHA:168) (Exim 3.31-VA-mm2 #1 (Debian)) id 18xtKE-0003B1-00 for ; Tue, 25 Mar 2003 10:39:06 -0800 Content-Disposition: inline In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Simmons Cc: Linux Kernel Mailing List , Linux Fbdev development list On Tue, Mar 25 2003, James Simmons wrote: > > As usually I have a patch avalaible at > > http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz > > drivers/video/aty/aty128fb.c | 16 +++++++--------- > drivers/video/console/fbcon.c | 4 ++-- > drivers/video/controlfb.c | 18 +++--------------- > drivers/video/platinumfb.c | 28 ++++++++-------------------- > drivers/video/radeonfb.c | 10 ++++++++++ > drivers/video/softcursor.c | 2 +- > 6 files changed, 31 insertions(+), 47 deletions(-) > > The patch has updates for the ATI Rage 128, Control, and Platnium > framebuffer driver. The Radeon patch adds PLL times for the R* series of > cards. Memory is now safe to allocate for the software cursor and inside > fbcon. There still are issues with syncing which cause the cursor on some > systems to become corrupt sometimes. - data = kmalloc(size, GFP_KERNEL); - mask = kmalloc(size, GFP_KERNEL); + data = kmalloc(size, GFP_ATOMIC); + mask = kmalloc(size, GFP_ATOMIC); if (cursor->set & FB_CUR_SETSIZE) { memset(data, 0xff, size); irk, you replaced GFP_KERNEL with GFP_ATOMIC, and even unconditionally memset the return without even bothering to check if it succeeded or not. -- Jens Axboe ------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en