tridentfb in 2.5.70 broken

tridentfb in 2.5.70 broken

[Bram Stolk]

Hi there,


tridentfb 0.7.8-NEWAPI, as shipping with linux-2.5.70 is broken.
in tridentfb_check_var(), the check for nativex should read:

        if (flatpanel && nativex && var->xres > nativex)

instead of:

	if (var->xres > nativex)

otherwise all modes are rejected on a non FP.

Also, the Documents/fb/ docs are out of date, with regard
to option passing.

And the comment in tridentfb.c
 * Parse user specified options (`video=trident:')
...is plain wrong.
Only 'video=tridentfb:' will work.

modedb.txt should include the 'tridentfb' target for video=
tridentfb.txt should be updated on how to pass parameters.

And last:
video=tridentfb:mode=800x600 does not work, as mode= is
not recognized. I think it should. Currently, you are forced to
skip the mode=, thus: video=tridentfb:800x600

  Regards,

     Bram Stolk



-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.

Re: tridentfb in 2.5.70 broken

[Jani Monoses]

> Hi there,
> 
> 
> tridentfb 0.7.8-NEWAPI, as shipping with linux-2.5.70 is broken.
> in tridentfb_check_var(), the check for nativex should read:
> 
>         if (flatpanel && nativex && var->xres > nativex)
> 
> instead of:
> 
> 	if (var->xres > nativex)
> 
> otherwise all modes are rejected on a non FP.

Feel free to send a patch, I don't have time right now, in fact I
haven't used 2.5 for a long time. In 2.5 all fbdevs now have the fb
suffix for consistency in boot args but the docs for trident were not
updated.
You can send the patch to this list hopefully it will be picked up by
somebody. If not I'll send it eventually .
thanks
Jani


-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.