fix for fbcon margins colour in 2.6 (question, not sure)

fix for fbcon margins colour in 2.6 (question, not sure)

[Jakub Bogusz]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Hello,

As I already mentioned in my last post about tdfxfb fix, I have a fix
for margins colour in 2.6 (tested on tdfxfb, but this issue is probably
general, not card-specific, as this code exists in fbcon.c), but I'm not
sure if it's 100% correct.

Up to 2.6.0-test2 (on tdfxfb after applying other needed patches, like
Richard Drummond's patch for image blits and my patch for clear colour)
sometimes (usually after vt switch) margins (e.g. half of line at the
bottom of screen when using 100x37 text mode on 800x600 physical mode)
change colour to the colour of some other regions of screen. It's
because margins are filled with attr_bgcol_ec(bgshift, vc) colour, not
black (or, more generally, text background, i.e. colour 0 of pseudo
palette).

Shouldn't text colour 0 always be used to clear margins?
I think it should...
Attached patch changes margins colour to 0, thus fixing issue mentioned
above. I haven't seen any side-effects.


-- 
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Linux       http://www.pld-linux.org/

[-- Attachment #2: linux-fbcon-margins.patch --]
[-- Type: text/plain, Size: 508 bytes --]

Shouldn't margins always have text colour 0?
Background of last erase character is definitely not what we want...

--- linux-2.6.0-test2/drivers/video/console/fbcon.c.orig	2003-07-14 05:36:32.000000000 +0200
+++ linux-2.6.0-test2/drivers/video/console/fbcon.c	2003-07-31 00:53:26.000000000 +0200
@@ -502,7 +502,7 @@
 	unsigned int bs = info->var.yres - bh;
 	struct fb_fillrect region;
 
-	region.color = attr_bgcol_ec(bgshift, vc);
+	region.color = 0;
 	region.rop = ROP_COPY;
 
 	if (rw && !bottom_only) {