Re: Re: New radeonfb, mostly untested

[Kronos <kronos@kronoz.cjb.net>]

Il Tue, Sep 09, 2003 at 11:07:31PM +0200, Benjamin Herrenschmidt ha scritto: 
> 
> > 
> > struct fb_info *framebuffer_alloc(size_t size, struct device *dev) {
> >         struct fb_info *ret;
> > 
> >         ret = kmalloc(sizeof(struct fb_info) + size, GFP_KERNEL);
> >         if (!ret)
> >                 return NULL;
> >         memset(ret, 0, sizeof(struct fb_info) + size);
> 
> Except I would also make sure that there is some alignement of the
> private part, if possible on L1 cache line size

struct fb_info *framebuffer_alloc(size_t size, struct device *dev) {
        unsigned char *ret;
        struct fb_info *info;
        int align;

        if (size)
                align = L1_CACHE_BYTES - (sizeof(struct fb_info) % L1_CACHE_BYTES);
        else
                align = 0;
        
        ret = kmalloc(sizeof(struct fb_info) + align + size, GFP_KERNEL);
        if (!ret)
                return NULL;
        memset(ret, 0, sizeof(struct fb_info) + size + align);
        info = (struct fb_info *)ret;
        info->class_dev.dev = dev;

        if (size)
                info->par = ret + align;

        return info;
}
                
How does it look? Is there a smarter way to do it?

Luca
-- 
Reply-To: kronos@kronoz.cjb.net
Home: http://kronoz.cjb.net
The trouble with computers is that they do what you tell them, 
not what you want.
D. Cohen


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf