From: Russell King <rmk@arm.linux.org.uk>
To: Kronos <kronos@kronoz.cjb.net>
Cc: linux-fbdev-devel@lists.sourceforge.net,
James Simmons <jsimmons@infradead.org>
Subject: Re: [PATCH] acornfb: New framebuffer_alloc API and class_dev changes
Date: Mon, 15 Sep 2003 22:05:11 +0100 [thread overview]
Message-ID: <20030915220511.F10328@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20030915193450.GC16370@dreamland.darkstar.lan>; from kronos@kronoz.cjb.net on Mon, Sep 15, 2003 at 09:34:50PM +0200
On Mon, Sep 15, 2003 at 09:34:50PM +0200, Kronos wrote:
> Hi,
> this patch convert driver/video/acorn.c to framebuffer_alloc:
This is buggy in places - it looks like you used 'sed' to make many
of these changes, and missed ones which crop up twice on one line.
> @@ -448,7 +448,7 @@
> * 1MB VRAM 32bit
> * 2MB VRAM 64bit
> */
> - if (current_par.using_vram && current_par.vram_half_sam == 2048) {
> + if (current_par->using_vram && current_par.vram_half_sam == 2048) {
> dat_ctl |= VIDC20_DCTL_BUS_D63_0;
> } else
> dat_ctl |= VIDC20_DCTL_BUS_D31_0;
> ...
> Luca
> --
> Reply-To: kronos@kronoz.cjb.net
> Home: http://kronoz.cjb.net
> This message will self distruct in 5 seconds.
Your timer appears to be malfunctioning.
--
Russell King (rmk@arm.linux.org.uk) http://www.arm.linux.org.uk/personal/
Linux kernel maintainer of:
2.6 ARM Linux - http://www.arm.linux.org.uk/
2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
next prev parent reply other threads:[~2003-09-15 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-15 19:34 [PATCH] acornfb: New framebuffer_alloc API and class_dev changes Kronos
2003-09-15 21:05 ` Russell King [this message]
2003-09-15 21:09 ` Kronos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030915220511.F10328@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=jsimmons@infradead.org \
--cc=kronos@kronoz.cjb.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).