From: Kronos <kronos@kronoz.cjb.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: James Simmons <jsimmons@infradead.org>
Subject: [PATCH] Fix get_std_timing
Date: Sat, 27 Sep 2003 19:28:43 +0200 [thread overview]
Message-ID: <20030927172843.GA14088@dreamland.darkstar.lan> (raw)
Hi James,
it seems that you lost the following patch. It fixes get_std_timing.
Current code doesn't search the VESA modedb. Instead it exits after the
first iteration with mode calculated by calc_mode_timings. Bug was
spotted by Antonino Daplas. Please apply:
===== drivers/video/fbmon.c 1.9 vs edited =====
--- 1.9/drivers/video/fbmon.c Wed Jun 4 07:55:19 2003
+++ edited/drivers/video/fbmon.c Mon Sep 15 17:59:28 2003
@@ -566,17 +566,19 @@
}
refresh = (block[1] & 0x3f) + 60;
+ /* First find standard mode from the table of VESA modes */
for (i = 0; i < VESA_MODEDB_SIZE; i++) {
if (vesa_modes[i].xres == xres &&
vesa_modes[i].yres == yres &&
vesa_modes[i].refresh == refresh) {
*mode = vesa_modes[i];
- break;
- } else {
- calc_mode_timings(xres, yres, refresh, mode);
- break;
+ return 1;
}
}
+
+ /* If mode is not found in table, calculate it using GTF */
+ calc_mode_timings(xres, yres, refresh, mode);
+
return 1;
}
Luca
--
Reply-To: kronos@kronoz.cjb.net
Home: http://kronoz.cjb.net
Windows /win'dohz/ n. : thirty-two bit extension and graphical shell to
a sixteen bit patch to an eight bit operating system originally coded
for a four bit microprocessor which was written by a two-bit company
that can't stand a bit of competition.
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
next reply other threads:[~2003-09-29 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-27 17:28 Kronos [this message]
2003-09-29 22:09 ` [PATCH] Fix get_std_timing James Simmons
-- strict thread matches above, loose matches on Subject: below --
2004-03-04 22:15 Kronos
2004-03-04 22:31 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030927172843.GA14088@dreamland.darkstar.lan \
--to=kronos@kronoz.cjb.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).