From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: FBDEV 2.6.0-test7 updates. Date: Wed, 15 Oct 2003 16:17:05 -0700 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <20031015161705.221a579b.akpm@osdl.org> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Cipher TLSv1:DES-CBC3-SHA:168) (Exim 3.31-VA-mm2 #1 (Debian)) id 1A9usw-0004Un-00 for ; Wed, 15 Oct 2003 16:16:54 -0700 Received: from fw.osdl.org ([65.172.181.6] helo=mail.osdl.org) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.22) id 1A9usv-00059g-OH for linux-fbdev-devel@lists.sourceforge.net; Wed, 15 Oct 2003 16:16:53 -0700 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: James Simmons Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chris Heath James Simmons wrote: > > Here is the latest fbdev patches. Please test!!! Many new enhancements. > Several fixes. The patch is against 2.6.0-test7 > > http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz Cool. I've had the below fix floating about for a while. Is it still relevant? From: Chris Heath I am still seeing a lot of cursors being left behind. It is not a race condition or anything -- in the TTY line editor, it happens about 50% of the time when you press backspace. What appears to be happening is the cursor is flashing twice as slowly as the driver thinks it is, so of course it's wrong half the time when it comes to erase the cursor. The patch below fixes it for me. drivers/video/softcursor.c | 6 ++++++ 1 files changed, 6 insertions(+) diff -puN drivers/video/softcursor.c~cursor-flashing-fix drivers/video/softcursor.c --- 25/drivers/video/softcursor.c~cursor-flashing-fix 2003-08-16 14:01:15.000000000 -0700 +++ 25-akpm/drivers/video/softcursor.c 2003-08-16 14:01:15.000000000 -0700 @@ -74,6 +74,12 @@ int soft_cursor(struct fb_info *info, st if (info->cursor.image.data) info->fbops->fb_imageblit(info, &info->cursor.image); + + if (!info->cursor.enable) { + for (i = 0; i < size; i++) + dst[i] ^= info->cursor.mask[i]; + } + return 0; } _ ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php