linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Bogusz <qboosh@pld-linux.org>
To: linux-kernel@vger.kernel.org
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] fix for fbcon margin colour in 2.6.0-test*
Date: Sat, 6 Dec 2003 02:34:25 +0100	[thread overview]
Message-ID: <20031206013425.GB3914@satan.blackhosts> (raw)

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Hello,

I posted this patch to fbdev-devel some time ago, but haven't got any
opinions there.
It sets fbcon margin colour to sane, black value, instead of changing
from time to time depending on background of last erase character
(more details inside).
It was tested by me on tdfxfb and one other person on matroxfb.


-- 
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Linux       http://www.pld-linux.org/

[-- Attachment #2: linux-fbcon-margins.patch --]
[-- Type: text/plain, Size: 840 bytes --]

This fixes "margin colour" (colour used to clear margins - e.g. a half of line
at the bottom of 100x37 console on 800x600 framebuffer).

I don't know what was the intention behind using attr_bgcol_ec() here, but it
caused using of background colour of last erase character to clear margins -
which definitely isn't what we want...
This patch changes margin colour to black (or colour 0 in palette modes).

	-- Jakub Bogusz <qboosh@pld-linux.org>

--- linux-2.6.0-test2/drivers/video/console/fbcon.c.orig	2003-07-14 05:36:32.000000000 +0200
+++ linux-2.6.0-test2/drivers/video/console/fbcon.c	2003-07-31 00:53:26.000000000 +0200
@@ -502,7 +502,7 @@
 	unsigned int bs = info->var.yres - bh;
 	struct fb_fillrect region;
 
-	region.color = attr_bgcol_ec(bgshift, vc);
+	region.color = 0;
 	region.rop = ROP_COPY;
 
 	if (rw && !bottom_only) {

                 reply	other threads:[~2003-12-06  1:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031206013425.GB3914@satan.blackhosts \
    --to=qboosh@pld-linux.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).