From: Andrew Morton <akpm@osdl.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, jsimmons@infradead.org
Subject: Re: [PATCH] kyrofb support
Date: Tue, 13 Jan 2004 18:09:26 -0800 [thread overview]
Message-ID: <20040113180926.5fdb0824.akpm@osdl.org> (raw)
In-Reply-To: <20040114013306.GB9515@linux-sh.org>
Paul Mundt <lethal@linux-sh.org> wrote:
>
> This patch adds support for the Kyro graphics boards (STG4000/PowerVR 3/etc.)
> to 2.6.1. This is a direct port and substantial cleanup / rewrite of the 2.4
> driver that's available in the sh64 tree at linux-sh.bkbits.net. Some of the
> overlay code and the STG4000 bits are still a bit ugly, so be forewarned.
Why is kyro_modedb[] and the code which touches it under #ifdef MODULE?
kyrofb_pci_tbl[] cannot be marked __devinitdata - it is linked into
system-wide PCI tables and will be walked at various times in the kernel.
If it is in a discarded section the kernel oopses.
Shouldn't the module_exit(kyrofb_exit); be inside #ifdef MODULE too?
In general, what are the fbdev drivers doing here btw? It's very strange
that some core file (fbmem.c) has to "know" about individual card drivers.
It should be sufficient for the driver to just register itself with the core
at the drivers's module_init() time.
Sigh. Too late to fix that now I guess.
-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
next prev parent reply other threads:[~2004-01-14 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 1:33 [PATCH] kyrofb support Paul Mundt
2004-01-14 1:49 ` Andrew Morton
2004-01-15 0:31 ` James Simmons
2004-01-14 2:09 ` Andrew Morton [this message]
2004-01-14 2:28 ` Paul Mundt
2004-01-14 12:45 ` Geert Uytterhoeven
2004-01-15 0:34 ` James Simmons
2004-01-15 0:36 ` James Simmons
2004-01-14 4:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113180926.5fdb0824.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jsimmons@infradead.org \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).