From: viro@parcelfarce.linux.theplanet.co.uk
To: Greg KH <greg@kroah.com>
Cc: James Simmons <jsimmons@infradead.org>,
Linus Torvalds <torvalds@transmeta.com>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: fbdev sysfs support.
Date: Sat, 7 Feb 2004 01:22:50 +0000 [thread overview]
Message-ID: <20040207012250.GS21151@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040207011916.GD4492@kroah.com>
On Fri, Feb 06, 2004 at 05:19:16PM -0800, Greg KH wrote:
> On Sat, Feb 07, 2004 at 01:10:48AM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Sat, Feb 07, 2004 at 01:01:35AM +0000, James Simmons wrote:
> > > +static void release_fb_info(struct class_device *class_dev)
> > > +{
> > > + struct fb_info *info = to_fb_info(class_dev);
> > > +
> > > + /* This doesn't harm */
> > > + fb_dealloc_cmap(&info->cmap);
> > > +
> > > + kfree(info);
> > > +}
> >
> > So what has happens when we hit existing kfree() on fb_info while sysfs
> > node is busy?
>
> This function will not get called until the sysfs node stops being busy,
> so it should all work properly. But only if that fb_info structure was
> allocated dynamically, unlike all of the current fb drivers (see my
> other comment about this patch.)
This function will not. Already existing kfree() in the drivers, OTOH, will.
next prev parent reply other threads:[~2004-02-07 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-07 0:34 fbdev sysfs support James Simmons
2004-02-07 0:59 ` Greg KH
2004-02-07 1:01 ` James Simmons
2004-02-07 1:10 ` viro
2004-02-07 1:19 ` Greg KH
2004-02-07 1:22 ` viro [this message]
2004-02-07 1:23 ` James Simmons
2004-02-07 1:28 ` Greg KH
2004-02-07 1:31 ` viro
2004-02-07 1:29 ` viro
2004-02-07 1:15 ` Greg KH
2004-02-07 1:24 ` viro
2004-02-07 1:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040207012250.GS21151@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=greg@kroah.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).