From: Kronos <kronos@kronoz.cjb.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: James Simmons <jsimmons@infradead.org>
Subject: [PATCH] Fix get_std_timing
Date: Thu, 4 Mar 2004 23:15:36 +0100 [thread overview]
Message-ID: <20040304221536.GA18093@dreamland.darkstar.lan> (raw)
Hi,
I thought that this was fixed ages ago, but I see that the bug it's still
here. To recap, get_std_timing will exit after the first iteration on
VESA modedb. Fix is trivial, James please apply:
--- linux-2.6/drivers/video/fbmon.c.orig Thu Mar 4 23:11:43 2004
+++ linux-2.6/drivers/video/fbmon.c Thu Mar 4 23:12:46 2004
@@ -572,12 +572,12 @@
vesa_modes[i].yres == yres &&
vesa_modes[i].refresh == refresh) {
*mode = vesa_modes[i];
- break;
- } else {
- calc_mode_timings(xres, yres, refresh, mode);
- break;
+ return 1;
}
}
+
+ calc_mode_timings(xres, yres, refresh, mode);
+
return 1;
}
Luca
--
Home: http://kronoz.cjb.net
Tentare e` il primo passo verso il fallimento.
Homer J. Simpson
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
next reply other threads:[~2004-03-04 22:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 22:15 Kronos [this message]
2004-03-04 22:31 ` [PATCH] Fix get_std_timing James Simmons
2004-03-05 2:37 ` Benjamin Herrenschmidt
2004-03-11 17:43 ` James Simmons
2004-03-11 17:50 ` Andrew Morton
2004-03-11 18:06 ` James Simmons
2004-03-11 18:13 ` Andrew Morton
2004-03-11 18:20 ` James Simmons
2004-03-11 22:49 ` Benjamin Herrenschmidt
2004-03-11 23:31 ` James Simmons
2004-03-12 23:46 ` character drawing enhancement James Simmons
2004-03-11 18:23 ` Re: [PATCH] Fix get_std_timing James Simmons
2004-03-11 22:48 ` Benjamin Herrenschmidt
2004-03-11 23:26 ` James Simmons
2004-03-11 18:29 ` Kronos
2004-03-11 19:32 ` James Simmons
2004-03-11 22:46 ` Benjamin Herrenschmidt
2004-03-11 23:32 ` James Simmons
-- strict thread matches above, loose matches on Subject: below --
2003-09-27 17:28 Kronos
2003-09-29 22:09 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304221536.GA18093@dreamland.darkstar.lan \
--to=kronos@kronoz.cjb.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).