From: Jon Smirl <jonsmirl@yahoo.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kronos <kronos@kronoz.cjb.net>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: Re: [PATCH] Remove voodoo code from i2c
Date: Fri, 5 Mar 2004 20:02:53 -0800 (PST) [thread overview]
Message-ID: <20040306040253.30871.qmail@web14913.mail.yahoo.com> (raw)
In-Reply-To: <1078544564.6327.146.camel@gaston>
--- Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Sat, 2004-03-06 at 13:10, Jon Smirl wrote:
> > Can this be written as a generic i2c probe function by calling i2c chanel
> > functions instead of directly calling radeon_gpio_setscl, etc? The i2c
> chanel
> > functions will then in turn call radeon_gpio_setscl, etc.
>
> Why ? we aren't doing normal i2c big banging here, just hacking
> around.
If I understand correctly, this code is needed to enable DDC on older monitors.
If this is the case it is a generic problem and it needs to be corrected in all
of the framebuffer drivers. Correcting it in all of the drivers is easier if the
code is written in the generic i2c form.
Also, how do we know this is working? Nobody can come up with one of the
monitors that needs this or even a spec describing it.
The discussion about this got started around a port of 2.4 ddcmon (i2c device
driver like eeprom) to 2.6 and sysfs. The code in the radeon driver is not in
ddcmon and the question is, should it be added? If it should be added it needs
to be converted to the i2c generic form, not the radeon specific one.
=====
Jon Smirl
jonsmirl@yahoo.com
__________________________________
Do you Yahoo!?
Yahoo! Search - Find what you’re looking for faster
http://search.yahoo.com
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
next prev parent reply other threads:[~2004-03-06 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-05 21:52 [PATCH] Remove voodoo code from i2c Kronos
2004-03-05 23:55 ` Benjamin Herrenschmidt
2004-03-06 0:47 ` Kronos
2004-03-06 2:10 ` Jon Smirl
2004-03-06 3:42 ` Benjamin Herrenschmidt
2004-03-06 4:02 ` Jon Smirl [this message]
2004-03-06 15:08 ` Kronos
2004-03-08 22:17 ` Richard Smith
2004-03-08 22:56 ` Benjamin Herrenschmidt
2004-03-06 0:12 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040306040253.30871.qmail@web14913.mail.yahoo.com \
--to=jonsmirl@yahoo.com \
--cc=benh@kernel.crashing.org \
--cc=kronos@kronoz.cjb.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).