From: Peter Samuelson <peter@p12n.org>
To: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: [uPATCH] matroxfb undefined parameter
Date: Thu, 18 Mar 2004 00:36:01 +0000 [thread overview]
Message-ID: <20040318003601.GA1105@p12n.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
With CONFIG_MTRR=n, the matroxfb_base module refuses to load properly,
because a MODULE_PARM doesn't have a corresponding global variable.
Trivial patch appended, please apply.
Peter
--- 2.6.4/drivers/video/matrox/matroxfb_base.c~ 2004-02-04 03:44:04.000000000 +0000
+++ 2.6.4/drivers/video/matrox/matroxfb_base.c 2004-03-18 00:23:20.000000000 +0000
@@ -2409,8 +2409,10 @@
MODULE_PARM_DESC(noinit, "Disables W/SG/SD-RAM and bus interface initialization (0 or 1=do not initialize) (default=0)");
MODULE_PARM(memtype, "i");
MODULE_PARM_DESC(memtype, "Memory type for G200/G400 (see Documentation/fb/matroxfb.txt for explanation) (default=3 for G200, 0 for G400)");
+#ifdef CONFIG_MTRR
MODULE_PARM(mtrr, "i");
MODULE_PARM_DESC(mtrr, "This speeds up video memory accesses (0=disabled or 1) (default=1)");
+#endif
MODULE_PARM(sgram, "i");
MODULE_PARM_DESC(sgram, "Indicates that G100/G200/G400 has SGRAM memory (0=SDRAM, 1=SGRAM) (default=0)");
MODULE_PARM(inv24, "i");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2004-03-18 0:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040318003601.GA1105@p12n.org \
--to=peter@p12n.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).