Re: [PATCH] neofb patches

[Alex Stewart <alex@foogod.com>]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

Well, I downloaded your diff for the neofb driver and tried it out.  I did
notice there appears to be a slight bug in it.  Whenever anything (such as
fbset) closes /dev/fb0, the driver clobbers the device registers (resulting in
a blank screen).

I'm assuming the attached correction is more what was intended..

I'm currently merging our two sets of patches into one driver.  I do note that
patch gets a little confused when trying to do it itself and places a couple of
bits of code in really odd places, which might have been part of why it didn't
work for you.  I think I should have an updated patchset ready to post later
tonight..

-alex

[-- Attachment #2: neofb-js.1.releasebug.patch --]
[-- Type: text/plain, Size: 414 bytes --]

--- drivers/video/neofb.c.jsimmons	2004-04-22 18:32:19.000000000 -0700
+++ drivers/video/neofb.c	2004-04-22 21:21:02.000000000 -0700
@@ -562,7 +562,7 @@
 	struct neofb_par *par = (struct neofb_par *) info->par;
 	int cnt = atomic_read(&par->ref_count);
 
-	if (cnt) {
+	if (!cnt) {
 		memset(&par->state, 0, sizeof(struct vgastate));
 		par->state.flags = VGA_SAVE_MODE | VGA_SAVE_FONTS;
 		save_vga(&par->state);