Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-)

[Otto Solares <solca@guug.org>]

On Thu, Apr 29, 2004 at 09:48:13PM +0200, Kronos wrote:
> Il Thu, Apr 29, 2004 at 12:11:42PM -0600, Otto Solares ha scritto: 
> > On Thu, Apr 29, 2004 at 07:01:00PM +0100, James Simmons wrote:
> > > 
> > > > > No we don't. We have the default modedb. I already tested a patch using 
> > > > > modedb. It works like a charm :-) I can stty all I want!!!! 
> > > > 
> > > > On your monitor... then most TFT owners will curse you :)
> > > 
> > > As we move from ioctls to sysfs we will also move from using 
> > > fb_var_screeninfo as the userland interface to using mode strings.
> > > That means when someone creates a string  like
> > > 
> > > 834x721@81 
> > > 
> > > then for non TFT monitors it should fail. For TFT monitors it will work.
> > > If someoone using stty ask for exotic mode then if the monitor is TFT then 
> > > it should work. Else it should fail. 
> > 
> > James: I have seen sysfs support for fbdev in the -mm series
> > from Kronoz I think, this sysfs interface that will obsolete
> > var_screeninfo and fix_screeninfo is 2.6 material?
> 
> Well, my patch uses class_simple to expose the framebuffer device so
> that udev can create /dev/fbN. Drivers can't touch the class_device
> (yet), for example radeonfb attaches edid info to the pci device, not to
> the framebuffer device. After the exams I will cook up a patch that
> should improve that.

Excellent news!

> > or we have to wait until 2.7 starts?
> 
> I think that for fully dynamic fb_info we should wait 2.7, the rest can
> go in 2.6. Resolution change via sysfs shouln't have a big impact on
> fbdev core.

I just would suggest as userspace fbdev consumer that is a pain to
do development using two different interfaces, if sysfs interface
will obsolete the ioctl one, it must have all the mechanics that
are present in the ioctl one so no mix of interfaces would be
required.

-otto



-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click