From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luiz Fernando N. Capitulino" Subject: [PATCH] - fix video/fbmem.c warning. Date: Fri, 30 Apr 2004 15:10:15 -0300 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <20040430181015.GB3119@lorien.prodam> Mime-Version: 1.0 Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1BJcYQ-0008Vi-1K for linux-fbdev-devel@lists.sourceforge.net; Fri, 30 Apr 2004 11:16:06 -0700 Received: from sampa7.prodam.sp.gov.br ([200.230.190.107]) by sc8-sf-mx2.sourceforge.net with esmtp (Exim 4.30) id 1BJcYP-00079p-JR for linux-fbdev-devel@lists.sourceforge.net; Fri, 30 Apr 2004 11:16:05 -0700 Content-Disposition: inline Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: James Simmons , linux-fbdev-devel Hi, The patch bellow fix this warning: drivers/video/fbmem.c: In function `fb_cursor': drivers/video/fbmem.c:922: warning: passing arg 1 of `copy_from_user' discards qualifiers from pointer target type It is only a cast (several other calls for copy_from_user() need that). drivers/video/fbmem.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -X dontdiff -Nparu a/drivers/video/fbmem.c a~/drivers/video/fbmem.c --- a/drivers/video/fbmem.c 2004-04-26 15:25:52.000000000 -0300 +++ a~/drivers/video/fbmem.c 2004-04-27 16:48:15.000000000 -0300 @@ -914,7 +914,7 @@ fb_cursor(struct fb_info *info, struct f return -ENOMEM; } - if (copy_from_user(cursor.image.data, sprite->image.data, size) || + if (copy_from_user((void *) cursor.image.data, sprite->image.data, size) || copy_from_user(cursor.mask, sprite->mask, size)) { kfree(cursor.image.data); kfree(cursor.mask); -- Luiz Fernando N. Capitulino ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click