Re: [PATCH] - fix video/fbmem.c warning.

[Andrew Morton <akpm@osdl.org>]

"Luiz Fernando N. Capitulino" <lcapitulino@prefeitura.sp.gov.br> wrote:
>
> 
>  Hi,
> 
>  The patch bellow fix this warning:
> 
>  drivers/video/fbmem.c: In function `fb_cursor':
>  drivers/video/fbmem.c:922: warning: passing arg 1 of `copy_from_user' discards qualifiers from pointer target type
> 
>  It is only a cast (several other calls for copy_from_user() need that).
> 
>  drivers/video/fbmem.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff -X dontdiff -Nparu a/drivers/video/fbmem.c a~/drivers/video/fbmem.c
> --- a/drivers/video/fbmem.c	2004-04-26 15:25:52.000000000 -0300
> +++ a~/drivers/video/fbmem.c	2004-04-27 16:48:15.000000000 -0300
> @@ -914,7 +914,7 @@ fb_cursor(struct fb_info *info, struct f
>  			return -ENOMEM;
>  		}
>  		
> -		if (copy_from_user(cursor.image.data, sprite->image.data, size) ||
> +		if (copy_from_user((void *) cursor.image.data, sprite->image.data, size) ||
>  		    copy_from_user(cursor.mask, sprite->mask, size)) { 
>  			kfree(cursor.image.data);
>  			kfree(cursor.mask);
> 

Why is fb_image.data declared to be a pointer to `const' data?  This
function proves that this assertion is false.

Would it not be better to remove the `const' qualifier?


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click