Re: Re: [PATCH] - video/tdfxfb.c warning fix.

["Luiz Fernando N. Capitulino" <lcapitulino@prefeitura.sp.gov.br>]

Em Sat, May 01, 2004 at 09:16:29PM +0200, Geert Uytterhoeven escreveu:

| On Sat, 1 May 2004, Andrew Morton wrote:
| > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
| > >  > You've taken a bunch of previously-working 3d acceleration functions and
| > >  > made them configurable, dependent upon CONFIG_EXPERIMENTAL.
| > >  >
| > >  > What on earth for?  Will this not gratuitously break people's
| > >  > previously-working 3d setups?
| > >
| > >  No, tdfxfb_cursor() was not used before, causing a compiler warning.
| > >  tdfxfb_cursor() may work, but we don't know, so we didn't dare to enable it by
| > >  default. Now the user (he who has the hardware) can enable it, and tell us
| > >  whether it works or not.
| >
| > OK, thanks.  As you can see, it really helps if people explain this sort of
| > thing in their initial patch (sigh).
| >
| > Does the same argument apply to this patch?
| 
| Yes. All these patches should enable the currently unused acceleration routines
| if the corresponding config option is set, and kill the compiler warnings if
| its not set.

 Humm, my fault. I thought my comments was enough, will try to make
better in next time.

PS: Andrew, I always need to think about "be very clear" vs "Andrew's time
to read e-mails". It is not a easy task. :-)

-- 
Luiz Fernando N. Capitulino
<http://www.telecentros.sp.gov.br>


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click