From: "Ville Syrjälä" <syrjala@sci.fi>
To: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] atyfb (2.6): Add RGB565 support
Date: Fri, 14 May 2004 07:53:34 +0300 [thread overview]
Message-ID: <20040514045334.GA2693@sci.fi> (raw)
In-Reply-To: <40A41CD3.2010908@undead.cc>
On Thu, May 13, 2004 at 09:11:47PM -0400, John Zielinski wrote:
> Geert Uytterhoeven wrote:
>
> >It's always possible there's a bug in fbtest w.r.t. 565 handling, but I
> >didn't
> >see it.
> >
> >
>
> It's a bug in fbtest's directcolor routines. Directcolor sets the clut
> using using the min of the RGB sizes so 565 becomes 555. The problem is
> that tests 4, 8 and 9 use the buffer as 565 (VISUAL_GENERIC &
> VISUAL_TRUECOLOR) and the directcolor routines don't reset the clut to
> it's full range. Fix attached.
Looks perfect with this patch.
However I just realized that the atyfb patch will not work correctly with
partial color map updates. Revised patch coming up...
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click
prev parent reply other threads:[~2004-05-14 4:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 21:36 [PATCH] atyfb (2.6): Add RGB565 support Ville Syrjälä
2004-05-12 9:11 ` Geert Uytterhoeven
2004-05-12 18:57 ` Ville Syrjälä
2004-05-13 9:22 ` Geert Uytterhoeven
2004-05-13 19:19 ` Ville Syrjälä
2004-05-14 1:11 ` John Zielinski
2004-05-14 4:53 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514045334.GA2693@sci.fi \
--to=syrjala@sci.fi \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).