From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: vga16fb broke
Date: Tue, 18 May 2004 17:38:45 -0700
Sender: linux-kernel-owner@vger.kernel.org
Message-ID: <20040518173845.1e03288c.akpm@osdl.org>
References: <20040518171612.516ad43c.akpm@osdl.org>
	<Pine.LNX.4.44.0405190117430.16503-100000@phoenix.infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner+linux-kernel=40quimby.gnus.org-S263714AbUESAgi@vger.kernel.org>
In-Reply-To: <Pine.LNX.4.44.0405190117430.16503-100000@phoenix.infradead.org>
List-Id: <fbdev-devel.lists.sourceforge.net
Content-Type: text/plain; charset="us-ascii"
To: James Simmons <jsimmons@infradead.org>
Cc: VANDROVE@vc.cvut.cz, vince@kyllikki.org, linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org

James Simmons <jsimmons@infradead.org> wrote:
>
> 
> > I have pondered your email at length and have failed to understand it.
> > 
> > I _think_ you're saying that we need to do this, which will fix x86:
> > 
> > --- 25/drivers/video/vga16fb.c~vga16fb-fix	Tue May 18 17:10:14 2004
> > +++ 25-akpm/drivers/video/vga16fb.c	Tue May 18 17:10:39 2004
> > @@ -1347,7 +1347,7 @@ int __init vga16fb_init(void)
> >  
> >  	/* XXX share VGA_FB_PHYS and I/O region with vgacon and others */
> >  
> > -	vga16fb.screen_base = ioremap(VGA_MAP_MEM(VGA_FB_PHYS), VGA_FB_PHYS_LEN);
> > +	vga16fb.screen_base = VGA_MAP_MEM(VGA_FB_PHYS);
> >  	if (!vga16fb.screen_base) {
> >  		printk(KERN_ERR "vga16fb: unable to map device\n");
> >  		ret = -ENOMEM;
> 
> This will make the driver on all platforms. 

There's a missing word in that sentence.  Was it "work" or "crash"?  This
matters ;)

> _
> > 
> > and that ARM and others need to teach their VGA_MAP_MEM() to do an internal
> > ioremap().
> > 
> > Or do you mean something else?  Please be more clear?
> 
> I like to see the VGA_MAP_MEM hack go away and be replaced with ioremap.

If you can cut a patch we can ask arch maintainers to review and test it.