linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Kropelin <akropel1@rochester.rr.com>
To: sparclinux@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Cc: jsimmons@infradead.org
Subject: [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC
Date: Sun, 6 Jun 2004 01:06:29 -0400	[thread overview]
Message-ID: <20040606010629.A23517@mail.kroptech.com> (raw)

When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
which quickly leads to an oops when fb_set_cmap() dereferences it.

First encountered in Aurora Wombat kernels and seems to afflict mainline
as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
anything to display on my CG6, but at least it no longer oopses the kernel.

Signed-off-by: Adam Kropelin <akropel1@rochester.rr.com>

--- linux-2.6.7-rc2/drivers/video/sbuslib.c	2004-05-09 22:32:27.000000000 -0400
+++ linux-2.6.7-rc2-adk/drivers/video/sbuslib.c	2004-06-06 04:10:52.682928000 -0400
@@ -122,6 +122,7 @@
 		cmap.red = &red;
 		cmap.green = &green;
 		cmap.blue = &blue;
+		cmap.transp = NULL;
 		for (i = 0; i < count; i++) {
 			int err;
 

             reply	other threads:[~2004-06-06  5:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-06  5:06 Adam Kropelin [this message]
2004-06-07  2:58 ` [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040606010629.A23517@mail.kroptech.com \
    --to=akropel1@rochester.rr.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).