* [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC
@ 2004-06-06 5:06 Adam Kropelin
2004-06-07 2:58 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Adam Kropelin @ 2004-06-06 5:06 UTC (permalink / raw)
To: sparclinux, linux-fbdev-devel; +Cc: jsimmons
When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
which quickly leads to an oops when fb_set_cmap() dereferences it.
First encountered in Aurora Wombat kernels and seems to afflict mainline
as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
anything to display on my CG6, but at least it no longer oopses the kernel.
Signed-off-by: Adam Kropelin <akropel1@rochester.rr.com>
--- linux-2.6.7-rc2/drivers/video/sbuslib.c 2004-05-09 22:32:27.000000000 -0400
+++ linux-2.6.7-rc2-adk/drivers/video/sbuslib.c 2004-06-06 04:10:52.682928000 -0400
@@ -122,6 +122,7 @@
cmap.red = &red;
cmap.green = &green;
cmap.blue = &blue;
+ cmap.transp = NULL;
for (i = 0; i < count; i++) {
int err;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC
2004-06-06 5:06 [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC Adam Kropelin
@ 2004-06-07 2:58 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-06-07 2:58 UTC (permalink / raw)
To: Adam Kropelin; +Cc: sparclinux, linux-fbdev-devel, jsimmons
On Sun, 6 Jun 2004 01:06:29 -0400
Adam Kropelin <akropel1@rochester.rr.com> wrote:
> When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
> which quickly leads to an oops when fb_set_cmap() dereferences it.
>
> First encountered in Aurora Wombat kernels and seems to afflict mainline
> as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
> anything to display on my CG6, but at least it no longer oopses the kernel.
>
> Signed-off-by: Adam Kropelin <akropel1@rochester.rr.com>
Applied, thanks a lot Adam.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-07 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-06 5:06 [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC Adam Kropelin
2004-06-07 2:58 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).