linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Thomas Winischhofer <thomas@winischhofer.net>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: 2.6.7 still garbage upon start
Date: Fri, 18 Jun 2004 18:04:58 +0800	[thread overview]
Message-ID: <200406181804.05653.adaplas@hotpop.com> (raw)
In-Reply-To: <40D29FCD.7020602@winischhofer.net>

On Friday 18 June 2004 15:54, Thomas Winischhofer wrote:
>
> > (I have code I'm planning to send for RFC that will notify the
> > low-level driver if switching from KD_GRAPHICS->KD_TEXT and vice
> > versa or if multiple drivers are mapped to different consoles.
> > However, it seems BenH already has code for this so I'm holding the
> > submission.  I just can't find BenH's changes in 2.6.7 or -mm.  Hey
> > Ben, where is it?)
>
> Perhaps I am being naive, but I don't understand what the problem can
> be. X restores the display mode before initiating the VT change. And a
> VT change should restore the previous screen contents.
>

True, most of the time, there's no problem switching to X as X does a good job 
of restoring its own state.  It's in the other direction, switching from X to 
VC, that fbcon must correctly determine if there is a need to restore the 
hardware state.

With the separation of fbcon and fbdev in 2.6.x, it is now fbcon which decides 
when to do a set_par or not.  Currently, a set_par (via set_var) is only 
called if the current var and the new var is not the same.  So, when you 
switch from  X's VC to the console, fbcon assumes  there was no state change 
(mistakenly, of course, from the POV of fbcon). This is because the current 
var (info->var) and the new_var (created in fbcon_switch->fbcon_resize) is 
the same. As you can see, this leaves fbdev in an undefined state.

So, one solution is to have fbcon detect a switch between consoles in which 
the old console is in graphics mode and the new console will be in text mode.  

Tony  
 




-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND

      parent reply	other threads:[~2004-06-18 10:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-17 22:41 2.6.7 still garbage upon start Thomas Winischhofer
2004-06-18  1:45 ` Antonino A. Daplas
2004-06-18  7:54   ` Thomas Winischhofer
2004-06-18  8:23     ` Geert Uytterhoeven
2004-06-18 13:08       ` John Zielinski
2004-06-18 13:18         ` Geert Uytterhoeven
2004-06-18 13:40           ` John Zielinski
2004-06-18 18:40           ` Antonino A. Daplas
2004-06-19  2:09             ` John Zielinski
2004-06-19  3:08             ` David Eger
2004-06-19  6:13               ` Antonino A. Daplas
2004-06-22  9:45                 ` David Eger
2004-06-22 13:20                   ` Antonino A. Daplas
2004-06-19 19:27             ` John Zielinski
2004-06-19 20:25               ` Antonino A. Daplas
2004-06-18 10:04     ` Antonino A. Daplas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200406181804.05653.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=adaplas@pol.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).