Re: [PATCH 3/3] [FBDEV]: Hardware State Notification

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Thursday 24 June 2004 10:35, Benjamin Herrenschmidt wrote:
> On Wed, 2004-06-23 at 18:50, Antonino A. Daplas wrote:
> > Thanks Ben, I see it now. I did not realize it was in the console_blank
> > hook.  (I did not follow this list for a time). And no, I don't think you
> > missed a code path.  The problem is that we are calling
> > fb_set_var->set_par too early, before X has really given up on the
> > hardware. We can fix this by setting some kind of flag while in
> > fbcon_blank,  and depending on the setting of this flag, force a set_par
> > in fbcon_switch instead.
> >
> > I'll concoct a patch later. (I'll test James' new patch first).
>
> That would be a bug in X
>
> If console switching, the 'unblank' is done, afaik, after X calls the ioctl
> to relinguish the console to the kernel.
>
> When exiting X, I'm not sure, but that should be similar. If X still
> touches the HW after that, it's an X bug (and yes, I does that, at least in
> the radeon driver, afaik)
>

Include nvidia into the list.  With the nv driver, the whole machine hangs. 
The i810 has cursor sprite corruption, but has a workaround for it.

So, I would still like to do the set_par as late as possible such as in 
fbcon_switch().  (BTW, this fixes the riva driver)

Tony




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com