[PATCH 3/3][FBDEV]: Set capabilities flag for vesafb and vga16fb

[PATCH 3/3][FBDEV]: Set capabilities flag for vesafb and vga16fb

[Antonino A. Daplas]

Hi,

This patch sets the correct capabilities flag for vesafb and vga16fb to provide fbcon
with the correct hints as to the best scrolling mode.

Tony

Signed-off-by: Antonino Daplas <adaplas@pol.net>

diff -Naur linux-2.6.7-mm6-orig/drivers/video/vesafb.c linux-2.6.7-mm6/drivers/video/vesafb.c
--- linux-2.6.7-mm6-orig/drivers/video/vesafb.c	2004-07-05 21:13:11.369469160 +0000
+++ linux-2.6.7-mm6/drivers/video/vesafb.c	2004-07-05 13:50:25.000000000 +0000
@@ -378,7 +378,8 @@
 	info->fbops = &vesafb_ops;
 	info->var = vesafb_defined;
 	info->fix = vesafb_fix;
-	info->flags = FBINFO_FLAG_DEFAULT;
+	info->flags = FBINFO_FLAG_DEFAULT |
+		(ypan) ? FBINFO_HWACCEL_YPAN : 0;
 
 	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) {
 		err = -ENXIO;
diff -Naur linux-2.6.7-mm6-orig/drivers/video/vga16fb.c linux-2.6.7-mm6/drivers/video/vga16fb.c
--- linux-2.6.7-mm6-orig/drivers/video/vga16fb.c	2004-07-05 21:13:21.050997344 +0000
+++ linux-2.6.7-mm6/drivers/video/vga16fb.c	2004-07-05 21:13:37.357518376 +0000
@@ -1370,7 +1370,8 @@
 	vga16fb.var = vga16fb_defined;
 	vga16fb.fix = vga16fb_fix;
 	vga16fb.par = &vga16_par;
-	vga16fb.flags = FBINFO_FLAG_DEFAULT;
+	vga16fb.flags = FBINFO_FLAG_DEFAULT |
+		FBINFO_HWACCEL_YPAN;
 
 	i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
 	ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Re: [PATCH 3/3][FBDEV]: Set capabilities flag for vesafb and vga16fb

[David Eger]

Thanks for getting these; I've been lazy and not gotten to them.

I do want FBINFO_FLAG_DEFAULT to go away though... it's now
FBINFO_DEFAULT.  I also don't see anything in vga16fb that precludes
FBINFO_HWACCEL_XPAN, though I don't see anyone who uses that flag,
either.  *shrug*

The big performance patch also looks like good work, though I've
not tested it.  Thanks :)

-dte


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Re: [PATCH 3/3][FBDEV]: Set capabilities flag for vesafb and vga16fb

[Antonino A. Daplas]

On Tuesday 06 July 2004 13:35, David Eger wrote:
> Thanks for getting these; I've been lazy and not gotten to them.
>

My intent was to demonstrate the PAN_REDRAW patch, and 
FBINFO_HWACCEL_YPAN must be set for that :-) And I chose
vesafb and vga16fb since they're the most commonly used drivers
in the x86 world.

> I do want FBINFO_FLAG_DEFAULT to go away though... it's now

Hmm, okay, I did not know that.

> FBINFO_DEFAULT.  I also don't see anything in vga16fb that precludes
> FBINFO_HWACCEL_XPAN, though I don't see anyone who uses that flag,
> either.  *shrug*

Well, fbcon does not use x-panning at all, so, yes, it's a useless flag, not
just for vga16fb but for all drivrers.  Userspace uses x-panning though, but 
they check xpanstep instead.

Tony




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com