Re: Fw: Rivafb I2C problem, new patch

[Greg KH <greg@kroah.com>]

On Mon, Jul 12, 2004 at 04:39:42PM -0700, Andrew Morton wrote:
> 
> Maybe Greg, or the linux-fbdev-devel denizens can comment upon
> this?
> 
> 
> Begin forwarded message:
> 
> Date: Tue, 13 Jul 2004 01:24:02 +0200
> From: Nicolas Boichat <nicolas@boichat.ch>
> To: akpm@digeo.com
> Subject: Rivafb I2C problem, new patch
> 
> 
> Hello,
> 
> I'm currently writing a DDC/CI tool for Linux (DDC/CI is the protocol
> which permits to modify monitor parameters without using the OSD), see
> http://www.boichat.ch/nicolas/ddcci .
> 
> I use the new rivafb I2C support, but a problem appeared: the I2C bus
> is immediately deleted after the DDC2 EDID is read, but I need to
> access it from my application!
> 
> I attached a patch which fixes this problem: the bus is deleted only
> when the driver is unloaded (please note that the atyfb behave like my
> patched version). Could you add it to the next -mm kernel release ?

Well, you shouldn't comment out those calls, just delete them.

Other than that, from an i2c standpoint, the patch looks sane, but I
would check with the maintainer, as there might be some reason they
delete the bus right after using it.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com