Re: [PATCH] atyfb: vblank irq support

[Alexander Kern <alex.kern@gmx.de>]

Am Sonntag, 25. Juli 2004 02:03 schrieb Antonino A. Daplas:
> On Sunday 25 July 2004 07:12, Alexander Kern wrote:
> > P.S. Now the last consumer from fb_load_cursor_image is neo driver.
> > Should we drop this function, it's buggy!
>
> We should.  fb_load_cursor_image() cannot be generic.
fine, do you make it for neo driver?
>
> > Steel on my TODO list:
> >
> > Issue with 16bpp mode, brocken boot logo, fbi has problems too.
>
> 1. aty128fb_setcolreg has this lines:
>
> 		case 16:
> 			pal[regno] = (regno << 11) | (regno << 6) | regno;
> 			break;
>
> Shouldn't it be?
>
> 		pal[regno] = (regno << 11) | (regno << 5) | regno;
>
Maybe, but I work on mach64 driver. In atyfb_base.c#2671 it is really
pal[regno] = (regno << 11) | (regno << 5) | regno;
> 2. In RGB555, isn't it better to fill up all the 8 slots per index per
> channel (256/32), instead of just (regno * 8)? For RGB565, that will be 8
> slots per red and blue, 4 slots per green (256/64).
>
> So something like this for RGB555, ie:
>
> 	for  (i = 0; i < 8; i++) {
> 		aty128_st_pal((regno * 8) + i, red, green, blue, par);
>
> RGB565 is a bit more complicated because green is deeper, but is doable.
>
> Tony
>
> DISCLAIMER: I know nothing about this hardware, I'm probably shooting
> blanks :-)


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click