Re: Re: [Question] Colour management

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Sunday 01 August 2004 06:18, Ville Syrjälä wrote:
> On Sat, Jul 31, 2004 at 06:26:27PM +0800, Antonino A. Daplas wrote:
> > On Saturday 31 July 2004 02:12, Alexander Kern wrote:
> > > Hallo Tony,
> > >
> > > can you explain the deep mining of fb_setcolreg. Background, I observe
> > > wrong palette using in 15 and 16 bpp modes, but can not understand,
> > > what is the right approach. In both cases from penguin logo I can see
> > > only contour in honey yellow and blue vertical string jsimmons, pretty
> > > scury ;-) The rest is black! The simple text or ncurses applications
> > > have always right colours. Additionally and only by 16bpp fbi shows
> > > blurry images. In 15bpp fbi works fine. fbtest works fine and his
> > > penguins look good in all resolutions ?!
> >
> > This will need a long answer. (For mistakes or ommisions, please let me
> > know)
> >
> > fb_setcolreg has 2 functions, initialize info->pseudopalette (if needed)
> > and initialize the hardware CLUT (if needed).
>
> BTW fb_setcolreg ends up writing half of the registers twice (more if you
> have to fill all slots). It might be better to have two functions. The
> first one would be the current fb_setcolreg except it wouldn't actually
> write anything. It would only fill in the correct register values. And the
> second one would write the clut to hardware. That would avoid the multiple
> writes.

Yes, we also need to separate the imageblit into a mono_src_color_expand
(for text drawing) and an 8_bit_src_color_expand (for the logo).  Both proposals
will affect all drivers so let's leave it as is for now (unless you want to risk
the ire again of the fbdev driver maintainers, they're a bit touchy from the
numerous breakages of the API :-)

Tony




-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com