Re: Re: [Question] Colour management

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Sunday 01 August 2004 06:10, Ville Syrjälä wrote:
> On Fri, Jul 30, 2004 at 08:12:36PM +0200, Alexander Kern wrote:
> > Hallo Tony,
> >
> > can you explain the deep mining of fb_setcolreg. Background, I observe
> > wrong palette using in 15 and 16 bpp modes, but can not understand, what
> > is the right approach. In both cases from penguin logo I can see only
> > contour in honey yellow and blue vertical string jsimmons, pretty scury
> > ;-) The rest is black! The simple text or ncurses applications have
> > always right colours. Additionally and only by 16bpp fbi shows blurry
> > images.
>
> I just had a look at the fbi code and it's wrong. It was initializing the
> clut to 555. The attached patch fixes the problem.

I know that this is just a test patch but instead of hardwiring the parameters 
of linear_palette, why not do:

linear_palette(var.red.length, var.green.length, var.blue.length)

This way you can catch unusual RGB combinations (ie, RGB484, if there is such 
a thing) and still get correct colors.  You can also eliminate the switch() 
statement, and makes it easier to catch fbdev bugs.

>
> I think the boot logo code is broken. No, I haven't actually looked at it
> but everything else works... Or does it work on some other directcolor hw?

Yes, the logo code is broken, not the drawing code itself, but the logo 
choosing code. As I've mentioned in another thread, 16-bit directcolor cannot 
draw 224-color logos.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com