Re: 2.6.8.1-mm2

Re: 2.6.8.1-mm2

[Andrew Morton]

(switched mailing lists)

Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
>
> On Thu, Aug 19, 2004 at 01:42:04AM -0700, Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.8.1/2.6.8.1-mm2/
> > 
> > - Added Tony Luck's ia64 devel tree to the -mm "external trees" lineup.
> > 
> > - The monster memory leak which some people were seeing with audio CD
> 
> Hi Andrew,
> 
> Just annoying your arse, I get this:
> 
>   LD      .tmp_vmlinux1
> drivers/built-in.o(.text+0xa1bde): In function `radeon_match_mode':
> : undefined reference to `vesa_modes'
> drivers/built-in.o(.text+0xa1cbd): In function `radeon_match_mode':
> : undefined reference to `vesa_modes'
> make: ** [.tmp_vmlinux1] Erro 1
> 
> Known already?

nope.  That symbol is exported to modules.

Please send .config.


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: 2.6.8.1-mm2

[Antonino A. Daplas]

On Friday 20 August 2004 14:08, Andrew Morton wrote:
> (switched mailing lists)
>
> Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
> > On Thu, Aug 19, 2004 at 01:42:04AM -0700, Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.8.1/2
> > >.6.8.1-mm2/
> > >
> > > - Added Tony Luck's ia64 devel tree to the -mm "external trees" lineup.
> > >
> > > - The monster memory leak which some people were seeing with audio CD
> >
> > Hi Andrew,
> >
> > Just annoying your arse, I get this:
> >
> >   LD      .tmp_vmlinux1
> >
> > drivers/built-in.o(.text+0xa1bde): In function `radeon_match_mode':
> > : undefined reference to `vesa_modes'
> >
> > drivers/built-in.o(.text+0xa1cbd): In function `radeon_match_mode':
> > : undefined reference to `vesa_modes'
> >
> > make: ** [.tmp_vmlinux1] Erro 1
> >
> > Known already?
>
> nope.  That symbol is exported to modules.
>

Oops.  vesa_modes is now dependent on CONFIG_FB_MODE_HELPERS.  
I'll submit a patch over the weekend to fix drivers that require this option.

Tony




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: 2.6.8.1-mm2

[Kronos]

Il Fri, Aug 20, 2004 at 05:11:26PM +0800, Antonino A. Daplas ha scritto: 
> > > drivers/built-in.o(.text+0xa1bde): In function `radeon_match_mode':
> > > : undefined reference to `vesa_modes'
> > >
> > > drivers/built-in.o(.text+0xa1cbd): In function `radeon_match_mode':
> > > : undefined reference to `vesa_modes'
> > >
> > > make: ** [.tmp_vmlinux1] Erro 1
> > >
> > > Known already?
> >
> > nope.  That symbol is exported to modules.
> >
> 
> Oops.  vesa_modes is now dependent on CONFIG_FB_MODE_HELPERS.  
> I'll submit a patch over the weekend to fix drivers that require this option.
> 
> Tony

Hi,
I sent the following patch a while ago. radeonfb, rivafb and i810fb need
CONFIG_FB_MODE_HELPERS the patch makes them select it: 

--- a/drivers/video/Kconfig	2004-08-09 17:03:58.000000000 +0200
+++ b/drivers/video/Kconfig	2004-08-09 17:04:56.000000000 +0200
@@ -437,6 +437,7 @@
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RIVA_I2C
 	select I2C if FB_RIVA_I2C
+	select FB_MODE_HELPERS
 	help
 	  This driver supports graphics boards with the nVidia Riva/Geforce
 	  chips.
@@ -469,6 +470,7 @@
 config FB_I810
 	tristate "Intel 810/815 support (EXPERIMENTAL)"
 	depends on FB && AGP && AGP_INTEL && EXPERIMENTAL && PCI	
+	select FB_MODE_HELPERS
 	help
 	  This driver supports the on-board graphics built in to the Intel 810 
           and 815 chipsets.  Say Y if you have and plan to use such a board.
@@ -672,6 +674,7 @@
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RADEON_I2C
 	select I2C if FB_RADEON_I2C
+	select FB_MODE_HELPERS
 	help
 	  Choose this option if you want to use an ATI Radeon graphics card as
 	  a framebuffer device.  There are both PCI and AGP versions.  You


Luca
-- 
Home: http://kronoz.cjb.net
Do, or do not. There is no try.


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285